[GitHub] [maven-assembly-plugin] hboutemy commented on a diff in pull request #143: [MASSEMBLY-988] Add support for new plexus-archiver formats, code cleanup

["hboutemy (via GitHub)" <gi...@apache.org>]

hboutemy commented on code in PR #143:
URL: https://github.com/apache/maven-assembly-plugin/pull/143#discussion_r1186746601


##########
src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java:
##########
@@ -475,19 +475,20 @@ public void execute() throws MojoExecutionException, MojoFailureException {
         // TODO: include dependencies marked for distribution under certain formats
         // TODO: how, might we plug this into an installer, such as NSIS?
 
-        MavenArchiver mavenArchiver = new MavenArchiver();
-        Date outputDate = mavenArchiver.parseOutputTimestamp(outputTimestamp);
+        FileTime outputDate = MavenArchiver.parseBuildOutputTimestamp(outputTimestamp)
+                .map(FileTime::from)
+                .orElse(null);

Review Comment:
   I find this new code so much more complicated...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org