You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@curator.apache.org by leventov <gi...@git.apache.org> on 2018/12/10 18:41:51 UTC

[GitHub] curator pull request #295: CURATOR-494 Make ZKPaths.makePath() methods to al...

GitHub user leventov opened a pull request:

    https://github.com/apache/curator/pull/295

    CURATOR-494 Make ZKPaths.makePath() methods to allocate less garbage

    Currently ZKPaths.makePath() methods call substring() unnecessarily. I've seen those methods responsible for 15% of total heap allocation in some application.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/leventov/curator ZKPaths-substring

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/295.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #295
    
----
commit 123a739f258d3d1c35e28454168a209936e51cde
Author: Roman Leventov <le...@...>
Date:   2018-12-10T18:37:52Z

    Make ZKPaths.makePath() methods to allocate less garbage

----


---

[GitHub] curator issue #295: CURATOR-494 Make ZKPaths.makePath() methods to allocate ...

Posted by Randgalt <gi...@git.apache.org>.

Github user Randgalt commented on the issue:

    https://github.com/apache/curator/pull/295
  
    Nice optimizations. Thank you. Once of us will review and merge shortly.


---

[GitHub] curator issue #295: CURATOR-494 Make ZKPaths.makePath() methods to allocate ...

Posted by leventov <gi...@git.apache.org>.

Github user leventov commented on the issue:

    https://github.com/apache/curator/pull/295
  
    Thank you!


---

[GitHub] curator pull request #295: CURATOR-494 Make ZKPaths.makePath() methods to al...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/curator/pull/295


---