[GitHub] [flink] rkhachatryan commented on pull request #19062: [FLINK-26592][state/changelog] Use mailbox in FsStateChangelogWriter instead of a lock

[GitBox <gi...@apache.org>]

rkhachatryan commented on pull request #19062:
URL: https://github.com/apache/flink/pull/19062#issuecomment-1073704791


   Thanks for the review @curcur, 
   
   I think your [question](https://github.com/apache/flink/pull/19062#issuecomment-1073473660) is not directly related to this PR.
   I'll try to answer it, but let's move the discussion to a separate ticket or to offline to unblock the fix.
   > Then in BatchingStateChangeUploadScheduler#scheduleUploadIfNeeded, the scheduled uploading is canceled if not having enough capacity
   
   I think you misread the code, `scheduleUploadIfNeeded` doesn't check the capacity; it checks the thresholds; and if they are reached then the upload is scheduled immediately instead of waiting for `scheduleDelayMs`:
   
   >  and goes into the retrying logic.
   
   Upload **always** go through the retry logic, but inside `drainAndSave`.
   
   > My question is why not before scheduling an upload task, just make sure it has enough capacity?
   
   Capacity **is** checked before starting an upload (and not afterwards).
   However, it is enough to have at least **some** capacity to proceed; otherwise, too big upload will never start.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org