[GitHub] [druid] cryptoe commented on a change in pull request #11723: Improve exception message when loading data from web-console

[GitBox <gi...@apache.org>]

cryptoe commented on a change in pull request #11723:
URL: https://github.com/apache/druid/pull/11723#discussion_r728864819



##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/sampler/SamplerExceptionMapper.java
##########
@@ -28,13 +29,21 @@
 @Provider
 public class SamplerExceptionMapper implements ExceptionMapper<SamplerException>
 {
+  private static final Logger LOG = new Logger(SamplerExceptionMapper.class);
+
   @Override
   public Response toResponse(SamplerException exception)
   {
+    String message = exception.getMessage() == null ? "The sampler encountered an issue" : exception.getMessage();
+
+    // stack trace is not returned to the client,
+    // so the cause of the exception should be logged so that we know where the exception is thrown
+    LOG.error(exception.getCause(), message);

Review comment:
       log the entire exception so that we get the stack trace ?
   We can return only the message to the UI but IMHO we should log the entire stack trace on the server side. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org