You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/03/09 03:48:16 UTC

[GitHub] [pulsar] sijie commented on a change in pull request #3795: Feature - implement reference count for ConsumerImpl

sijie commented on a change in pull request #3795: Feature - implement reference count for ConsumerImpl
URL: https://github.com/apache/pulsar/pull/3795#discussion_r263985162
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
 ##########
 @@ -253,6 +253,10 @@ public UnAckedMessageTracker getUnAckedMessageTracker() {
 
     @Override
     public CompletableFuture<Void> unsubscribeAsync() {
+        if (!shouldTearDown()) {
 
 Review comment:
   I don't think we need this for `unsubscribe`.
   
   technically if any consumer in a subscription unsubscribe, the subscription is unsubscribed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services