You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Paul Benedict <pb...@apache.org> on 2014/11/07 06:15:42 UTC
@required attribute
I noticed our free marker templates are outputting required="true" into the
HTML fields. This is invalid HTML. It needs to be required (name with no
value) or required="required" for XHTML.
Cheers,
Paul
Re: @required attribute
Posted by Rene Gielen <re...@gmail.com>.
We kind of broke it already. Currently it looks broken in either way to me.
I think we should try for the best possible fix that has clear semantics
and an "easy-enough" migration path.
I'd also suggest to discuss this further in the mentioned JIRA ticket to
have a straight issue history.
- René
Am 07.11.2014 22:02 schrieb "Paul Benedict" <pb...@apache.org>:
> I'd rather break everything at once. That's how I feel about it. I don't
> want to keep on telling users migration plans from 2.3 to 2.5 and 2.5 to
> 3.0
>
>
> Cheers,
> Paul
>
> On Fri, Nov 7, 2014 at 8:59 AM, Lukasz Lenart <lu...@apache.org>
> wrote:
>
> > 2014-11-07 15:56 GMT+01:00 Paul Benedict <pb...@apache.org>:
> > > I keep telling Lukasz we need to build 3.0 -- but he hasn't taken my
> > advice
> > > yet :-)
> >
> > We can skip 2.5 if you think that's better - but we will have a lot of
> > changes at once
> >
> >
> > Regards
> > --
> > Łukasz
> > + 48 606 323 122 http://www.lenart.org.pl/
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
> >
>
Re: @required attribute
Posted by Paul Benedict <pb...@apache.org>.
I'd rather break everything at once. That's how I feel about it. I don't
want to keep on telling users migration plans from 2.3 to 2.5 and 2.5 to 3.0
Cheers,
Paul
On Fri, Nov 7, 2014 at 8:59 AM, Lukasz Lenart <lu...@apache.org>
wrote:
> 2014-11-07 15:56 GMT+01:00 Paul Benedict <pb...@apache.org>:
> > I keep telling Lukasz we need to build 3.0 -- but he hasn't taken my
> advice
> > yet :-)
>
> We can skip 2.5 if you think that's better - but we will have a lot of
> changes at once
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: @required attribute
Posted by Lukasz Lenart <lu...@apache.org>.
2014-11-07 15:56 GMT+01:00 Paul Benedict <pb...@apache.org>:
> I keep telling Lukasz we need to build 3.0 -- but he hasn't taken my advice
> yet :-)
We can skip 2.5 if you think that's better - but we will have a lot of
changes at once
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: @required attribute
Posted by Paul Benedict <pb...@apache.org>.
I keep telling Lukasz we need to build 3.0 -- but he hasn't taken my advice
yet :-)
Cheers,
Paul
On Fri, Nov 7, 2014 at 7:10 AM, Dave Newton <da...@gmail.com> wrote:
> I'd vote for following HTML5 as closely as possible.
>
> I'm okay with a backwards-incompatible change for the next large-ish
> release.
>
>
>
> On Fri, Nov 7, 2014 at 12:25 AM, Lukasz Lenart <lu...@apache.org>
> wrote:
> > 2014-11-07 6:15 GMT+01:00 Paul Benedict <pb...@apache.org>:
> >> I noticed our free marker templates are outputting required="true" into
> the
> >> HTML fields. This is invalid HTML. It needs to be required (name with no
> >> value) or required="required" for XHTML.
> >
> > Here is discussion about that
> > https://issues.apache.org/jira/browse/WW-4188
> >
> > and here is the original issue
> > https://issues.apache.org/jira/browse/WW-3908
> >
> > I really need someone's advice how to proceed
> >
> >
> > Regards
> > --
> > Łukasz
> > + 48 606 323 122 http://www.lenart.org.pl/
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
>
>
>
> --
> e: davelnewton@gmail.com
> m: 908-380-8699
> s: davelnewton_skype
> t: @dave_newton
> b: Bucky Bits
> g: davelnewton
> so: Dave Newton
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: @required attribute
Posted by Dave Newton <da...@gmail.com>.
I'd vote for following HTML5 as closely as possible.
I'm okay with a backwards-incompatible change for the next large-ish release.
On Fri, Nov 7, 2014 at 12:25 AM, Lukasz Lenart <lu...@apache.org> wrote:
> 2014-11-07 6:15 GMT+01:00 Paul Benedict <pb...@apache.org>:
>> I noticed our free marker templates are outputting required="true" into the
>> HTML fields. This is invalid HTML. It needs to be required (name with no
>> value) or required="required" for XHTML.
>
> Here is discussion about that
> https://issues.apache.org/jira/browse/WW-4188
>
> and here is the original issue
> https://issues.apache.org/jira/browse/WW-3908
>
> I really need someone's advice how to proceed
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
--
e: davelnewton@gmail.com
m: 908-380-8699
s: davelnewton_skype
t: @dave_newton
b: Bucky Bits
g: davelnewton
so: Dave Newton
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: @required attribute
Posted by Lukasz Lenart <lu...@apache.org>.
2014-11-07 6:15 GMT+01:00 Paul Benedict <pb...@apache.org>:
> I noticed our free marker templates are outputting required="true" into the
> HTML fields. This is invalid HTML. It needs to be required (name with no
> value) or required="required" for XHTML.
Here is discussion about that
https://issues.apache.org/jira/browse/WW-4188
and here is the original issue
https://issues.apache.org/jira/browse/WW-3908
I really need someone's advice how to proceed
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org