[GitHub] [tinkerpop] FlorianHockmann commented on issue #1122: Expose Connection Status to Client

[GitBox <gi...@apache.org>]

FlorianHockmann commented on issue #1122: Expose Connection Status to Client
URL: https://github.com/apache/tinkerpop/pull/1122#issuecomment-499408416
 
 
   @github5775 First of all, thanks for reporting this problem and putting in the effort to improve the driver!
   I would just suggest that you [create an issue](https://issues.apache.org/jira/browse/TINKERPOP/) first in the future as that allows us to discuss about the problem and different ways to handle it before you create a PR.
   
   I'm actually not sure whether we want to expose the connection status to users. What are they supposed to do with that information?
   I think it makes more sense for us to decide whether we want to fail fast in this case or attempt to re-connect to the server (and then fail if that doesn't work).
   
   The second approach seems to make most sense as it allows us to handle the problem without the user even noticing it and if we can't reconnect, it becomes easier for users to handle that as they just have to catch an exception.
   A closed connection should be an exceptional case and therefore we shouldn't require users to check before each request whether the connection is closed in my opinion.
   
   @jorgebay What's your take on this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services