Re: [PR] MINOR: Change the ProducerConfig constructor that allows disabling logging to "protected" [kafka]

["cadonna (via GitHub)" <gi...@apache.org>]

cadonna commented on code in PR #14681:
URL: https://github.com/apache/kafka/pull/14681#discussion_r1378591228


##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -618,7 +618,7 @@ public ProducerConfig(Map<String, Object> props) {
         super(CONFIG, props);
     }
 
-    ProducerConfig(Map<?, ?> props, boolean doLog) {
+    protected ProducerConfig(Map<?, ?> props, boolean doLog) {

Review Comment:
   Changing the visibility to `protected` is actually a change in the public API since it changes the javadocs (https://kafka.apache.org/36/javadoc/org/apache/kafka/clients/consumer/ConsumerConfig.html) which are the source of truth for the public API. However, since it is a small addition (it want break backwards compatibility), I am fine with it.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org