You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/10 14:58:35 UTC
[GitHub] [beam] coheigea opened a new pull request #12512: BEAM-10668 - Replace toLowerCase().equals() with equalsIgnoreCase
coheigea opened a new pull request #12512:
URL: https://github.com/apache/beam/pull/12512
There are a couple of instances in the code where toLowerCase().equals() is used, when equalsIgnoreCase() would suffice. The latter is more concise + also doesn't involve the default Locale that's used with toLowerCase(), which might be problematic depending on the String being compared.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #12512: BEAM-10668 - Replace toLowerCase().equals() with equalsIgnoreCase
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on pull request #12512:
URL: https://github.com/apache/beam/pull/12512#issuecomment-671439244
Run Spotless PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev merged pull request #12512: [BEAM-10668] Replace toLowerCase().equals() with equalsIgnoreCase
Posted by GitBox <gi...@apache.org>.
aromanenko-dev merged pull request #12512:
URL: https://github.com/apache/beam/pull/12512
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] coheigea commented on pull request #12512: BEAM-10668 - Replace toLowerCase().equals() with equalsIgnoreCase
Posted by GitBox <gi...@apache.org>.
coheigea commented on pull request #12512:
URL: https://github.com/apache/beam/pull/12512#issuecomment-671407269
@aromanenko-dev
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org