[jira] [Commented] (METRON-1411) Fix sed command in Upgrading.md

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331319#comment-16331319 ] 

ASF GitHub Bot commented on METRON-1411:
----------------------------------------

GitHub user justinleet opened a pull request:

    https://github.com/apache/metron/pull/900

    METRON-1411: Fix sed command in Upgrading.md

    ## Contributor Comments
    The sed commands in Upgrading.md for the alert field can be problematic on some versions of sed, including what's on Vagrant if you ran the instructions from there.
    
    The commands will fail with a file not found error as-is (and can be tested by running the old version).  When running the new versions, the intended result is correct: The wrapping chunk with the template name is removed, and the alerts field is added.  Removing the wrapping chunk is to make it possible to resubmit to ES (Because it doesn't give an immediately resubmittable version), and the alert field is for querying.
    
    This can be tested by spinning up full dev, running the old versions and seeing the error, followed by running the new version successfully.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). 
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/justinleet/metron upgrading_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/900.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #900
    
----
commit 128e15fdad8016a9dc7578c0c1868fbd919c9cf9
Author: justinjleet <ju...@...>
Date:   2018-01-18T22:00:54Z

    Removing extraneous single quotes

----


> Fix sed command in Upgrading.md
> -------------------------------
>
>                 Key: METRON-1411
>                 URL: https://issues.apache.org/jira/browse/METRON-1411
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Justin Leet
>            Assignee: Justin Leet
>            Priority: Minor
>
> There's an extra pair of single quotes that causes problems on some sed versions.  Just need to drop them, there were extraneous anyway.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)