You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/14 12:28:43 UTC
[GitHub] [flink] 1996fanrui opened a new pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
1996fanrui opened a new pull request #18365:
URL: https://github.com/apache/flink/pull/18365
## What is the purpose of the change
Reuse tpc connections between taskmanagers
## Brief change log
Reuse tpc connections between taskmanagers.
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
*(Please pick either of the following options)*
This change added tests and can be verified as follows:
Added test that PartitionRequestClientFactoryTest#testReuseNettyPartitionRequestClient.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? JavaDocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
wsry commented on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1016097587
I will help to merge after all tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
wsry commented on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1014231754
@1996fanrui Thanks for your update. The change LGTM. Let's wait for @pnowojski review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
pnowojski commented on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1015442403
Thanks @1996fanrui , can you squash the commits before merging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #18365:
URL: https://github.com/apache/flink/pull/18365#discussion_r785620947
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientFactoryTest.java
##########
@@ -112,6 +115,35 @@ public void testExceptionsAreNotCached() throws Exception {
}
}
+ @Test
+ public void testReuseNettyPartitionRequestClient() throws Exception {
+ NettyTestUtil.NettyServerAndClient nettyServerAndClient = createNettyServerAndClient();
+ try {
+ checkReuseNettyPartitionRequestClient(nettyServerAndClient, 1);
+ checkReuseNettyPartitionRequestClient(nettyServerAndClient, 2);
+ checkReuseNettyPartitionRequestClient(nettyServerAndClient, 5);
+ checkReuseNettyPartitionRequestClient(nettyServerAndClient, 10);
+ } finally {
+ nettyServerAndClient.client().shutdown();
+ nettyServerAndClient.server().shutdown();
+ }
+ }
+
+ private void checkReuseNettyPartitionRequestClient(
+ NettyTestUtil.NettyServerAndClient nettyServerAndClient, int maxNumberOfConnections)
+ throws Exception {
+ Set<NettyPartitionRequestClient> set = new HashSet<>();
+
+ final PartitionRequestClientFactory factory =
+ new PartitionRequestClientFactory(
+ nettyServerAndClient.client(), 0, maxNumberOfConnections);
+ for (int i = 0; i < Math.max(100, maxNumberOfConnections); i++) {
+ final ConnectionID connectionID = nettyServerAndClient.getConnectionID(i);
+ set.add(factory.createPartitionRequestClient(connectionID));
+ }
+ assertEquals(maxNumberOfConnections, set.size());
Review comment:
Maybe using a random connection index and replace this assertion with ```assertTrue(set.size() <= maxNumberOfConnections);``` which is more like the real case?
In the current implementation, the selection of connection index value (1 - 100) and the modulus operation (%) guarantee that it can pass, but it seems that this case is not common enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on a change in pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on a change in pull request #18365:
URL: https://github.com/apache/flink/pull/18365#discussion_r785639386
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientFactoryTest.java
##########
@@ -112,6 +115,35 @@ public void testExceptionsAreNotCached() throws Exception {
}
}
+ @Test
+ public void testReuseNettyPartitionRequestClient() throws Exception {
+ NettyTestUtil.NettyServerAndClient nettyServerAndClient = createNettyServerAndClient();
+ try {
+ checkReuseNettyPartitionRequestClient(nettyServerAndClient, 1);
+ checkReuseNettyPartitionRequestClient(nettyServerAndClient, 2);
+ checkReuseNettyPartitionRequestClient(nettyServerAndClient, 5);
+ checkReuseNettyPartitionRequestClient(nettyServerAndClient, 10);
+ } finally {
+ nettyServerAndClient.client().shutdown();
+ nettyServerAndClient.server().shutdown();
+ }
+ }
+
+ private void checkReuseNettyPartitionRequestClient(
+ NettyTestUtil.NettyServerAndClient nettyServerAndClient, int maxNumberOfConnections)
+ throws Exception {
+ Set<NettyPartitionRequestClient> set = new HashSet<>();
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
}, {
"hash" : "39228325201d57243fd118cd66c30f24ed62125c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521",
"triggerID" : "39228325201d57243fd118cd66c30f24ed62125c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0fb50f41cbb5a39b421b909869934039d91e7c75 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459)
* 39228325201d57243fd118cd66c30f24ed62125c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
}, {
"hash" : "39228325201d57243fd118cd66c30f24ed62125c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521",
"triggerID" : "39228325201d57243fd118cd66c30f24ed62125c",
"triggerType" : "PUSH"
}, {
"hash" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29524",
"triggerID" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0fb50f41cbb5a39b421b909869934039d91e7c75 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459)
* 39228325201d57243fd118cd66c30f24ed62125c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521)
* ccea8f5fbc5e210d009dca55ffb566b2b7ea5437 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29524)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
}, {
"hash" : "39228325201d57243fd118cd66c30f24ed62125c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521",
"triggerID" : "39228325201d57243fd118cd66c30f24ed62125c",
"triggerType" : "PUSH"
}, {
"hash" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29524",
"triggerID" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"triggerType" : "PUSH"
}, {
"hash" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29610",
"triggerID" : "1015094837",
"triggerType" : "MANUAL"
}, {
"hash" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29610",
"triggerID" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1015094837",
"triggerType" : "MANUAL"
}, {
"hash" : "22c8ded41179db1141351bb78cebcd77e8d35b2c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29671",
"triggerID" : "22c8ded41179db1141351bb78cebcd77e8d35b2c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 51ec010668d8237bb8e02de3848126a9a7f19620 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29610)
* 22c8ded41179db1141351bb78cebcd77e8d35b2c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29671)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
}, {
"hash" : "39228325201d57243fd118cd66c30f24ed62125c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521",
"triggerID" : "39228325201d57243fd118cd66c30f24ed62125c",
"triggerType" : "PUSH"
}, {
"hash" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0fb50f41cbb5a39b421b909869934039d91e7c75 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459)
* 39228325201d57243fd118cd66c30f24ed62125c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521)
* ccea8f5fbc5e210d009dca55ffb566b2b7ea5437 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on a change in pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on a change in pull request #18365:
URL: https://github.com/apache/flink/pull/18365#discussion_r785655328
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientFactoryTest.java
##########
@@ -112,6 +115,35 @@ public void testExceptionsAreNotCached() throws Exception {
}
}
+ @Test
+ public void testReuseNettyPartitionRequestClient() throws Exception {
+ NettyTestUtil.NettyServerAndClient nettyServerAndClient = createNettyServerAndClient();
+ try {
+ checkReuseNettyPartitionRequestClient(nettyServerAndClient, 1);
+ checkReuseNettyPartitionRequestClient(nettyServerAndClient, 2);
+ checkReuseNettyPartitionRequestClient(nettyServerAndClient, 5);
+ checkReuseNettyPartitionRequestClient(nettyServerAndClient, 10);
+ } finally {
+ nettyServerAndClient.client().shutdown();
+ nettyServerAndClient.server().shutdown();
+ }
+ }
+
+ private void checkReuseNettyPartitionRequestClient(
+ NettyTestUtil.NettyServerAndClient nettyServerAndClient, int maxNumberOfConnections)
+ throws Exception {
+ Set<NettyPartitionRequestClient> set = new HashSet<>();
+
+ final PartitionRequestClientFactory factory =
+ new PartitionRequestClientFactory(
+ nettyServerAndClient.client(), 0, maxNumberOfConnections);
+ for (int i = 0; i < Math.max(100, maxNumberOfConnections); i++) {
+ final ConnectionID connectionID = nettyServerAndClient.getConnectionID(i);
+ set.add(factory.createPartitionRequestClient(connectionID));
+ }
+ assertEquals(maxNumberOfConnections, set.size());
Review comment:
Got it, thanks for your clarification and reminder. I've got more information from IntermediateResult and resubmit this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui removed a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
1996fanrui removed a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1015007385
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
}, {
"hash" : "39228325201d57243fd118cd66c30f24ed62125c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521",
"triggerID" : "39228325201d57243fd118cd66c30f24ed62125c",
"triggerType" : "PUSH"
}, {
"hash" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29524",
"triggerID" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"triggerType" : "PUSH"
}, {
"hash" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1015094837",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1015094837",
"triggerType" : "MANUAL"
}, {
"hash" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 51ec010668d8237bb8e02de3848126a9a7f19620 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
}, {
"hash" : "39228325201d57243fd118cd66c30f24ed62125c",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521",
"triggerID" : "39228325201d57243fd118cd66c30f24ed62125c",
"triggerType" : "PUSH"
}, {
"hash" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29524",
"triggerID" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 39228325201d57243fd118cd66c30f24ed62125c Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521)
* ccea8f5fbc5e210d009dca55ffb566b2b7ea5437 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29524)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
}, {
"hash" : "39228325201d57243fd118cd66c30f24ed62125c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "39228325201d57243fd118cd66c30f24ed62125c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0fb50f41cbb5a39b421b909869934039d91e7c75 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459)
* 39228325201d57243fd118cd66c30f24ed62125c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1016011073
> Thanks @1996fanrui , can you squash the commits before merging?
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1015007385
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
}, {
"hash" : "39228325201d57243fd118cd66c30f24ed62125c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521",
"triggerID" : "39228325201d57243fd118cd66c30f24ed62125c",
"triggerType" : "PUSH"
}, {
"hash" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29524",
"triggerID" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"triggerType" : "PUSH"
}, {
"hash" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29610",
"triggerID" : "1015094837",
"triggerType" : "MANUAL"
}, {
"hash" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29610",
"triggerID" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1015094837",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 51ec010668d8237bb8e02de3848126a9a7f19620 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29610)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1015094837
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 603a326550b51b4d9b8823c7fda81a2cdf4b9647 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441)
* 0fb50f41cbb5a39b421b909869934039d91e7c75 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #18365:
URL: https://github.com/apache/flink/pull/18365#discussion_r785618029
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientFactoryTest.java
##########
@@ -112,6 +115,35 @@ public void testExceptionsAreNotCached() throws Exception {
}
}
+ @Test
+ public void testReuseNettyPartitionRequestClient() throws Exception {
+ NettyTestUtil.NettyServerAndClient nettyServerAndClient = createNettyServerAndClient();
+ try {
+ checkReuseNettyPartitionRequestClient(nettyServerAndClient, 1);
+ checkReuseNettyPartitionRequestClient(nettyServerAndClient, 2);
+ checkReuseNettyPartitionRequestClient(nettyServerAndClient, 5);
+ checkReuseNettyPartitionRequestClient(nettyServerAndClient, 10);
+ } finally {
+ nettyServerAndClient.client().shutdown();
+ nettyServerAndClient.server().shutdown();
+ }
+ }
+
+ private void checkReuseNettyPartitionRequestClient(
+ NettyTestUtil.NettyServerAndClient nettyServerAndClient, int maxNumberOfConnections)
+ throws Exception {
+ Set<NettyPartitionRequestClient> set = new HashSet<>();
Review comment:
nit: can be final
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
}, {
"hash" : "39228325201d57243fd118cd66c30f24ed62125c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521",
"triggerID" : "39228325201d57243fd118cd66c30f24ed62125c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0fb50f41cbb5a39b421b909869934039d91e7c75 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459)
* 39228325201d57243fd118cd66c30f24ed62125c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
}, {
"hash" : "39228325201d57243fd118cd66c30f24ed62125c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521",
"triggerID" : "39228325201d57243fd118cd66c30f24ed62125c",
"triggerType" : "PUSH"
}, {
"hash" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29524",
"triggerID" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"triggerType" : "PUSH"
}, {
"hash" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29610",
"triggerID" : "1015094837",
"triggerType" : "MANUAL"
}, {
"hash" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29610",
"triggerID" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1015094837",
"triggerType" : "MANUAL"
}, {
"hash" : "22c8ded41179db1141351bb78cebcd77e8d35b2c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29671",
"triggerID" : "22c8ded41179db1141351bb78cebcd77e8d35b2c",
"triggerType" : "PUSH"
}, {
"hash" : "22c8ded41179db1141351bb78cebcd77e8d35b2c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29671",
"triggerID" : "1016430188",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 22c8ded41179db1141351bb78cebcd77e8d35b2c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29671)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
}, {
"hash" : "39228325201d57243fd118cd66c30f24ed62125c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521",
"triggerID" : "39228325201d57243fd118cd66c30f24ed62125c",
"triggerType" : "PUSH"
}, {
"hash" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29524",
"triggerID" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"triggerType" : "PUSH"
}, {
"hash" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29610",
"triggerID" : "1015094837",
"triggerType" : "MANUAL"
}, {
"hash" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29610",
"triggerID" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1015094837",
"triggerType" : "MANUAL"
}, {
"hash" : "22c8ded41179db1141351bb78cebcd77e8d35b2c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29671",
"triggerID" : "22c8ded41179db1141351bb78cebcd77e8d35b2c",
"triggerType" : "PUSH"
}, {
"hash" : "22c8ded41179db1141351bb78cebcd77e8d35b2c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29671",
"triggerID" : "1016430188",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 22c8ded41179db1141351bb78cebcd77e8d35b2c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29671)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui removed a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
1996fanrui removed a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1015030623
@pnowojski It seems the test failure isn't related with this PR. There is a table ci failure and previous ci is ok. I try to run azure again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
}, {
"hash" : "39228325201d57243fd118cd66c30f24ed62125c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521",
"triggerID" : "39228325201d57243fd118cd66c30f24ed62125c",
"triggerType" : "PUSH"
}, {
"hash" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0fb50f41cbb5a39b421b909869934039d91e7c75 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459)
* 39228325201d57243fd118cd66c30f24ed62125c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521)
* ccea8f5fbc5e210d009dca55ffb566b2b7ea5437 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
}, {
"hash" : "39228325201d57243fd118cd66c30f24ed62125c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521",
"triggerID" : "39228325201d57243fd118cd66c30f24ed62125c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0fb50f41cbb5a39b421b909869934039d91e7c75 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459)
* 39228325201d57243fd118cd66c30f24ed62125c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
}, {
"hash" : "39228325201d57243fd118cd66c30f24ed62125c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521",
"triggerID" : "39228325201d57243fd118cd66c30f24ed62125c",
"triggerType" : "PUSH"
}, {
"hash" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0fb50f41cbb5a39b421b909869934039d91e7c75 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459)
* 39228325201d57243fd118cd66c30f24ed62125c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521)
* ccea8f5fbc5e210d009dca55ffb566b2b7ea5437 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0fb50f41cbb5a39b421b909869934039d91e7c75 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
}, {
"hash" : "39228325201d57243fd118cd66c30f24ed62125c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521",
"triggerID" : "39228325201d57243fd118cd66c30f24ed62125c",
"triggerType" : "PUSH"
}, {
"hash" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29524",
"triggerID" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"triggerType" : "PUSH"
}, {
"hash" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29610",
"triggerID" : "1015094837",
"triggerType" : "MANUAL"
}, {
"hash" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29610",
"triggerID" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1015094837",
"triggerType" : "MANUAL"
}, {
"hash" : "22c8ded41179db1141351bb78cebcd77e8d35b2c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29671",
"triggerID" : "22c8ded41179db1141351bb78cebcd77e8d35b2c",
"triggerType" : "PUSH"
}, {
"hash" : "22c8ded41179db1141351bb78cebcd77e8d35b2c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29671",
"triggerID" : "1016430188",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 22c8ded41179db1141351bb78cebcd77e8d35b2c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29671)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 603a326550b51b4d9b8823c7fda81a2cdf4b9647 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #18365:
URL: https://github.com/apache/flink/pull/18365#discussion_r785651059
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientFactoryTest.java
##########
@@ -112,6 +115,35 @@ public void testExceptionsAreNotCached() throws Exception {
}
}
+ @Test
+ public void testReuseNettyPartitionRequestClient() throws Exception {
+ NettyTestUtil.NettyServerAndClient nettyServerAndClient = createNettyServerAndClient();
+ try {
+ checkReuseNettyPartitionRequestClient(nettyServerAndClient, 1);
+ checkReuseNettyPartitionRequestClient(nettyServerAndClient, 2);
+ checkReuseNettyPartitionRequestClient(nettyServerAndClient, 5);
+ checkReuseNettyPartitionRequestClient(nettyServerAndClient, 10);
+ } finally {
+ nettyServerAndClient.client().shutdown();
+ nettyServerAndClient.server().shutdown();
+ }
+ }
+
+ private void checkReuseNettyPartitionRequestClient(
+ NettyTestUtil.NettyServerAndClient nettyServerAndClient, int maxNumberOfConnections)
+ throws Exception {
+ Set<NettyPartitionRequestClient> set = new HashSet<>();
+
+ final PartitionRequestClientFactory factory =
+ new PartitionRequestClientFactory(
+ nettyServerAndClient.client(), 0, maxNumberOfConnections);
+ for (int i = 0; i < Math.max(100, maxNumberOfConnections); i++) {
+ final ConnectionID connectionID = nettyServerAndClient.getConnectionID(i);
+ set.add(factory.createPartitionRequestClient(connectionID));
+ }
+ assertEquals(maxNumberOfConnections, set.size());
Review comment:
@1996fanrui Hi, thanks for your update. Maybe I did not express it clearly which caused misunderstanding. I mean to use random connection index, not random connection index count. Because the real connection index is also randomly generated, you can refer to the IntermediateResult class for more information. In a word, I mean something like this:
```
final Random random = new Random();
for (int i = 0; i < Math.max(100, maxNumberOfConnections); i++) {
final ConnectionID connectionID =
nettyServerAndClient.getConnectionID(random.nextInt(Integer.MAX_VALUE));
set.add(factory.createPartitionRequestClient(connectionID));
}
assertTrue(set.size() <= maxNumberOfConnections);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
}, {
"hash" : "39228325201d57243fd118cd66c30f24ed62125c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521",
"triggerID" : "39228325201d57243fd118cd66c30f24ed62125c",
"triggerType" : "PUSH"
}, {
"hash" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29524",
"triggerID" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"triggerType" : "PUSH"
}, {
"hash" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29610",
"triggerID" : "1015094837",
"triggerType" : "MANUAL"
}, {
"hash" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29610",
"triggerID" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1015094837",
"triggerType" : "MANUAL"
}, {
"hash" : "22c8ded41179db1141351bb78cebcd77e8d35b2c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29671",
"triggerID" : "22c8ded41179db1141351bb78cebcd77e8d35b2c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22c8ded41179db1141351bb78cebcd77e8d35b2c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29671)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
wsry commented on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1016430188
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1015030623
@pnowojski It seems the test failure isn't related with this PR. There is a table ci failure and previous ci is ok. I try to run azure again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
}, {
"hash" : "39228325201d57243fd118cd66c30f24ed62125c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521",
"triggerID" : "39228325201d57243fd118cd66c30f24ed62125c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0fb50f41cbb5a39b421b909869934039d91e7c75 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459)
* 39228325201d57243fd118cd66c30f24ed62125c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
}, {
"hash" : "39228325201d57243fd118cd66c30f24ed62125c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521",
"triggerID" : "39228325201d57243fd118cd66c30f24ed62125c",
"triggerType" : "PUSH"
}, {
"hash" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29524",
"triggerID" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1015094837",
"triggerType" : "MANUAL"
}, {
"hash" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29610",
"triggerID" : "1015094837",
"triggerType" : "MANUAL"
}, {
"hash" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29610",
"triggerID" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 51ec010668d8237bb8e02de3848126a9a7f19620 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29610)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on a change in pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on a change in pull request #18365:
URL: https://github.com/apache/flink/pull/18365#discussion_r785640419
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientFactoryTest.java
##########
@@ -112,6 +115,35 @@ public void testExceptionsAreNotCached() throws Exception {
}
}
+ @Test
+ public void testReuseNettyPartitionRequestClient() throws Exception {
+ NettyTestUtil.NettyServerAndClient nettyServerAndClient = createNettyServerAndClient();
+ try {
+ checkReuseNettyPartitionRequestClient(nettyServerAndClient, 1);
+ checkReuseNettyPartitionRequestClient(nettyServerAndClient, 2);
+ checkReuseNettyPartitionRequestClient(nettyServerAndClient, 5);
+ checkReuseNettyPartitionRequestClient(nettyServerAndClient, 10);
+ } finally {
+ nettyServerAndClient.client().shutdown();
+ nettyServerAndClient.server().shutdown();
+ }
+ }
+
+ private void checkReuseNettyPartitionRequestClient(
+ NettyTestUtil.NettyServerAndClient nettyServerAndClient, int maxNumberOfConnections)
+ throws Exception {
+ Set<NettyPartitionRequestClient> set = new HashSet<>();
+
+ final PartitionRequestClientFactory factory =
+ new PartitionRequestClientFactory(
+ nettyServerAndClient.client(), 0, maxNumberOfConnections);
+ for (int i = 0; i < Math.max(100, maxNumberOfConnections); i++) {
+ final ConnectionID connectionID = nettyServerAndClient.getConnectionID(i);
+ set.add(factory.createPartitionRequestClient(connectionID));
+ }
+ assertEquals(maxNumberOfConnections, set.size());
Review comment:
Hi @wsry , thanks for your review. I have addressed these comments. Please help to review again when you are free. Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013080538
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 603a326550b51b4d9b8823c7fda81a2cdf4b9647 (Fri Jan 14 12:34:15 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
}, {
"hash" : "39228325201d57243fd118cd66c30f24ed62125c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521",
"triggerID" : "39228325201d57243fd118cd66c30f24ed62125c",
"triggerType" : "PUSH"
}, {
"hash" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0fb50f41cbb5a39b421b909869934039d91e7c75 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459)
* 39228325201d57243fd118cd66c30f24ed62125c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521)
* ccea8f5fbc5e210d009dca55ffb566b2b7ea5437 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 603a326550b51b4d9b8823c7fda81a2cdf4b9647 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 603a326550b51b4d9b8823c7fda81a2cdf4b9647 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441)
* 0fb50f41cbb5a39b421b909869934039d91e7c75 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
wsry commented on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1015082277
@1996fanrui Maybe rebasing the latest master can make the tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1016312675
Hi @wsry , do I need rerun CI again? It looks like kafka/gelly's IntegrationTest is failing and should not be related with this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1015283667
Hi @wsry @pnowojski , thanks for your help and review. Currently, the test has succeeded. A pleasant community journey!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
wsry commented on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1017101035
Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry closed pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
wsry closed pull request #18365:
URL: https://github.com/apache/flink/pull/18365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
}, {
"hash" : "39228325201d57243fd118cd66c30f24ed62125c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521",
"triggerID" : "39228325201d57243fd118cd66c30f24ed62125c",
"triggerType" : "PUSH"
}, {
"hash" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29524",
"triggerID" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"triggerType" : "PUSH"
}, {
"hash" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29610",
"triggerID" : "1015094837",
"triggerType" : "MANUAL"
}, {
"hash" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29610",
"triggerID" : "51ec010668d8237bb8e02de3848126a9a7f19620",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1015094837",
"triggerType" : "MANUAL"
}, {
"hash" : "22c8ded41179db1141351bb78cebcd77e8d35b2c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "22c8ded41179db1141351bb78cebcd77e8d35b2c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 51ec010668d8237bb8e02de3848126a9a7f19620 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29610)
* 22c8ded41179db1141351bb78cebcd77e8d35b2c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 603a326550b51b4d9b8823c7fda81a2cdf4b9647 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441)
* 0fb50f41cbb5a39b421b909869934039d91e7c75 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1013081147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29441",
"triggerID" : "603a326550b51b4d9b8823c7fda81a2cdf4b9647",
"triggerType" : "PUSH"
}, {
"hash" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29459",
"triggerID" : "0fb50f41cbb5a39b421b909869934039d91e7c75",
"triggerType" : "PUSH"
}, {
"hash" : "39228325201d57243fd118cd66c30f24ed62125c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29521",
"triggerID" : "39228325201d57243fd118cd66c30f24ed62125c",
"triggerType" : "PUSH"
}, {
"hash" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29524",
"triggerID" : "ccea8f5fbc5e210d009dca55ffb566b2b7ea5437",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ccea8f5fbc5e210d009dca55ffb566b2b7ea5437 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29524)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui removed a comment on pull request #18365: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
1996fanrui removed a comment on pull request #18365:
URL: https://github.com/apache/flink/pull/18365#issuecomment-1015094837
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org