You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "haiyanghan (via GitHub)" <gi...@apache.org> on 2023/05/24 06:03:07 UTC

[GitHub] [rocketmq] haiyanghan commented on a diff in pull request #6730: [ISSUE apache#6726] Fix bug DefaultMQProducer#request method invoke t…

haiyanghan commented on code in PR #6730:
URL: https://github.com/apache/rocketmq/pull/6730#discussion_r1203487256


##########
broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java:
##########
@@ -1025,9 +1025,7 @@ public void registerProcessor() {
         replyMessageProcessor.registerSendMessageHook(sendMessageHookList);
 
         this.remotingServer.registerProcessor(RequestCode.SEND_REPLY_MESSAGE, replyMessageProcessor, replyMessageExecutor);
-        this.remotingServer.registerProcessor(RequestCode.SEND_REPLY_MESSAGE_V2, replyMessageProcessor, replyMessageExecutor);

Review Comment:
   there may compatibility issues, A better way is to add a new one SEND_REPLY_MESSAGE_V3 message code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org