You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/14 09:26:57 UTC
[GitHub] [shardingsphere] cheese8 opened a new pull request, #17651: SPI-00001: No implementation class load from SPI `org.apache.shardingsphere.sqltranslator.spi.SQLTranslator`
cheese8 opened a new pull request, #17651:
URL: https://github.com/apache/shardingsphere/pull/17651
Changes proposed in this pull request:
-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] cheese8 commented on pull request #17651: SPI-00001: No implementation class load from SPI `org.apache.shardingsphere.sqltranslator.spi.SQLTranslator`
Posted by GitBox <gi...@apache.org>.
cheese8 commented on PR #17651:
URL: https://github.com/apache/shardingsphere/pull/17651#issuecomment-1126685385
> The trunk branch build failed ,and when this PR will be merged ? 😔
Yes, I am try to fix the trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] cheese8 closed pull request #17651: SPI-00001: No implementation class load from SPI `org.apache.shardingsphere.sqltranslator.spi.SQLTranslator`
Posted by GitBox <gi...@apache.org>.
cheese8 closed pull request #17651: SPI-00001: No implementation class load from SPI `org.apache.shardingsphere.sqltranslator.spi.SQLTranslator`
URL: https://github.com/apache/shardingsphere/pull/17651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #17651: SPI-00001: No implementation class load from SPI `org.apache.shardingsphere.sqltranslator.spi.SQLTranslator`
Posted by GitBox <gi...@apache.org>.
terrymanu commented on code in PR #17651:
URL: https://github.com/apache/shardingsphere/pull/17651#discussion_r872961979
##########
shardingsphere-kernel/shardingsphere-sql-translator/shardingsphere-sql-translator-core/pom.xml:
##########
@@ -33,5 +33,10 @@
<artifactId>shardingsphere-sql-translator-api</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.shardingsphere</groupId>
+ <artifactId>shardingsphere-sql-translator-native-provider</artifactId>
+ <version>${project.version}</version>
+ </dependency>
Review Comment:
Core module should not aware the provider modules
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] cheese8 commented on a diff in pull request #17651: SPI-00001: No implementation class load from SPI `org.apache.shardingsphere.sqltranslator.spi.SQLTranslator`
Posted by GitBox <gi...@apache.org>.
cheese8 commented on code in PR #17651:
URL: https://github.com/apache/shardingsphere/pull/17651#discussion_r872962665
##########
shardingsphere-kernel/shardingsphere-sql-translator/shardingsphere-sql-translator-core/pom.xml:
##########
@@ -33,5 +33,10 @@
<artifactId>shardingsphere-sql-translator-api</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.shardingsphere</groupId>
+ <artifactId>shardingsphere-sql-translator-native-provider</artifactId>
+ <version>${project.version}</version>
+ </dependency>
Review Comment:
move this import to shardingsphere-infra-rewrite module? @terrymanu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] misselvexu commented on pull request #17651: SPI-00001: No implementation class load from SPI `org.apache.shardingsphere.sqltranslator.spi.SQLTranslator`
Posted by GitBox <gi...@apache.org>.
misselvexu commented on PR #17651:
URL: https://github.com/apache/shardingsphere/pull/17651#issuecomment-1126684619
The trunk branch build failed ,and when this PR will be merged ? 😔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org