You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "codope (via GitHub)" <gi...@apache.org> on 2024/12/13 12:34:09 UTC
[PR] [HUDI-8767] Add bundle validation for release artifacts in Maven central [hudi]
codope opened a new pull request, #12488:
URL: https://github.com/apache/hudi/pull/12488
### Change Logs
Currently, we have bundle validation for artifacts staged in nexus repo. To ensure the necessary bundles are released to maven central, we should validate the bundles after they appear in maven central.
- Add bundle validation for release artifacts in maven central
- Update release guide to run this validation after artifacts appear in maven central
- Update how to run this validation in bundle validation README
### Impact
Ensuring release artifacts in Maven central are valid.
### Risk level (write none, low medium or high below)
none
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none"._
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8767] Add bundle validation for release artifacts in Maven central [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12488:
URL: https://github.com/apache/hudi/pull/12488#issuecomment-2541490518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "59c44295e207788d5cc0e7ced15da86314244a2d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2420",
"triggerID" : "59c44295e207788d5cc0e7ced15da86314244a2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 59c44295e207788d5cc0e7ced15da86314244a2d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2420)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8767] Add bundle validation for release artifacts in Maven central [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12488:
URL: https://github.com/apache/hudi/pull/12488#issuecomment-2628817253
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "59c44295e207788d5cc0e7ced15da86314244a2d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2420",
"triggerID" : "59c44295e207788d5cc0e7ced15da86314244a2d",
"triggerType" : "PUSH"
}, {
"hash" : "a30d79092a60c71653835deaa62ed5d3c2dad3fa",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3330",
"triggerID" : "a30d79092a60c71653835deaa62ed5d3c2dad3fa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 59c44295e207788d5cc0e7ced15da86314244a2d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2420)
* a30d79092a60c71653835deaa62ed5d3c2dad3fa Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3330)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8767] Add bundle validation for release artifacts in Maven central [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12488:
URL: https://github.com/apache/hudi/pull/12488#issuecomment-2628826454
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "59c44295e207788d5cc0e7ced15da86314244a2d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2420",
"triggerID" : "59c44295e207788d5cc0e7ced15da86314244a2d",
"triggerType" : "PUSH"
}, {
"hash" : "a30d79092a60c71653835deaa62ed5d3c2dad3fa",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3330",
"triggerID" : "a30d79092a60c71653835deaa62ed5d3c2dad3fa",
"triggerType" : "PUSH"
}, {
"hash" : "65f70347e582fc735d52c7d72a15654c089afd3a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "65f70347e582fc735d52c7d72a15654c089afd3a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 59c44295e207788d5cc0e7ced15da86314244a2d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2420)
* a30d79092a60c71653835deaa62ed5d3c2dad3fa Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3330)
* 65f70347e582fc735d52c7d72a15654c089afd3a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8767] Add bundle validation for release artifacts in Maven central [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #12488:
URL: https://github.com/apache/hudi/pull/12488#discussion_r1884221127
##########
.github/workflows/release_candidate_validation.yml:
##########
@@ -77,3 +77,68 @@ jobs:
if: ${{ env.SPARK_PROFILE >= 'spark3.3' }} # Only Spark 3.3 and above support Java 17
run: |
./packaging/bundle-validation/ci_run.sh hudi_docker_java17 $HUDI_VERSION openjdk17 $STAGING_REPO_NUM
+
+ validate-release-maven-artifacts:
Review Comment:
Should we add this validation to a new yaml file `maven_release_validation.yml` since after the artifacts are published they are no longer in release candidate so the logic doesn't fit into `release_candidate_validation.yml`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8767] Add bundle validation for release artifacts in Maven central [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #12488:
URL: https://github.com/apache/hudi/pull/12488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8767] Add bundle validation for release artifacts in Maven central [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #12488:
URL: https://github.com/apache/hudi/pull/12488#discussion_r1938216769
##########
.github/workflows/release_candidate_validation.yml:
##########
@@ -77,3 +77,68 @@ jobs:
if: ${{ env.SPARK_PROFILE >= 'spark3.3' }} # Only Spark 3.3 and above support Java 17
run: |
./packaging/bundle-validation/ci_run.sh hudi_docker_java17 $HUDI_VERSION openjdk17 $STAGING_REPO_NUM
+
+ validate-release-maven-artifacts:
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8767] Add bundle validation for release artifacts in Maven central [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12488:
URL: https://github.com/apache/hudi/pull/12488#issuecomment-2628826956
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "59c44295e207788d5cc0e7ced15da86314244a2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2420",
"triggerID" : "59c44295e207788d5cc0e7ced15da86314244a2d",
"triggerType" : "PUSH"
}, {
"hash" : "a30d79092a60c71653835deaa62ed5d3c2dad3fa",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3330",
"triggerID" : "a30d79092a60c71653835deaa62ed5d3c2dad3fa",
"triggerType" : "PUSH"
}, {
"hash" : "65f70347e582fc735d52c7d72a15654c089afd3a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "65f70347e582fc735d52c7d72a15654c089afd3a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a30d79092a60c71653835deaa62ed5d3c2dad3fa Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3330)
* 65f70347e582fc735d52c7d72a15654c089afd3a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8767] Add bundle validation for release artifacts in Maven central [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #12488:
URL: https://github.com/apache/hudi/pull/12488#issuecomment-2628832430
The maven artifact validation workflow is validated in https://github.com/apache/hudi/pull/12757/checks
<img width="379" alt="Screenshot 2025-01-31 at 23 39 04" src="https://github.com/user-attachments/assets/9534e0f3-d5ce-409c-88fc-9d6bce12d6c3" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8767] Add bundle validation for release artifacts in Maven central [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12488:
URL: https://github.com/apache/hudi/pull/12488#issuecomment-2541354699
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "59c44295e207788d5cc0e7ced15da86314244a2d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "59c44295e207788d5cc0e7ced15da86314244a2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 59c44295e207788d5cc0e7ced15da86314244a2d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8767] Add bundle validation for release artifacts in Maven central [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12488:
URL: https://github.com/apache/hudi/pull/12488#issuecomment-2541357399
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "59c44295e207788d5cc0e7ced15da86314244a2d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2420",
"triggerID" : "59c44295e207788d5cc0e7ced15da86314244a2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 59c44295e207788d5cc0e7ced15da86314244a2d Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2420)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8767] Add bundle validation for release artifacts in Maven central [hudi]
Posted by "codope (via GitHub)" <gi...@apache.org>.
codope commented on code in PR #12488:
URL: https://github.com/apache/hudi/pull/12488#discussion_r1883884005
##########
.github/workflows/release_candidate_validation.yml:
##########
@@ -77,3 +77,68 @@ jobs:
if: ${{ env.SPARK_PROFILE >= 'spark3.3' }} # Only Spark 3.3 and above support Java 17
run: |
./packaging/bundle-validation/ci_run.sh hudi_docker_java17 $HUDI_VERSION openjdk17 $STAGING_REPO_NUM
+
+ validate-release-maven-artifacts:
+ runs-on: ubuntu-latest
+ if: false
Review Comment:
I had created separate PR #12486 with this action turned on and Maven artifact validation succeeded - https://github.com/apache/hudi/actions/runs/12312424031/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8767] Add bundle validation for release artifacts in Maven central [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12488:
URL: https://github.com/apache/hudi/pull/12488#issuecomment-2628816754
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "59c44295e207788d5cc0e7ced15da86314244a2d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2420",
"triggerID" : "59c44295e207788d5cc0e7ced15da86314244a2d",
"triggerType" : "PUSH"
}, {
"hash" : "a30d79092a60c71653835deaa62ed5d3c2dad3fa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a30d79092a60c71653835deaa62ed5d3c2dad3fa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 59c44295e207788d5cc0e7ced15da86314244a2d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2420)
* a30d79092a60c71653835deaa62ed5d3c2dad3fa UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org