You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "htynkn (GitHub)" <gi...@apache.org> on 2018/10/14 14:46:10 UTC
[GitHub] [incubator-dubbo] htynkn opened pull request #2643: Jacoco
aggregate report
## What is the purpose of the change
JaCoCo Maven goals used to work on single modules only: Tests are executed within the module and contributed coverage only to code within the same module.
Dubbo is a multi module project which combine by api and their implements, current configuration is not suitable for Dubbo. Coverage reports were created for each module separately.
In order to get right test coverage, we can use new goal `maven goal jacoco:report-aggregate`. This report aggregates coverage data across Maven modules.
## Brief changelog
Change maven configuration.
## Verifying this change
CI pass and coverage increase.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2643 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] htynkn commented on issue #2643: Jacoco
aggregate report
Posted by "htynkn (GitHub)" <gi...@apache.org>.
> @htynkn need to back port to 2.6.x?
@diecui1202 I don't think so. because test coverage is one thing to help we improving code quality. 2.6.x is a maintain branch, we don't have any plan and resource to force on test. Let's force this part on master branch
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2643 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] diecui1202 commented on issue #2643:
Jacoco aggregate report
Posted by "diecui1202 (GitHub)" <gi...@apache.org>.
@htynkn need to back port to 2.6.x?
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2643 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] diecui1202 closed pull request #2643:
Jacoco aggregate report
Posted by "diecui1202 (GitHub)" <gi...@apache.org>.
[ pull request closed by diecui1202 ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2643 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2643:
Jacoco aggregate report
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2643?src=pr&el=h1) Report
> Merging [#2643](https://codecov.io/gh/apache/incubator-dubbo/pull/2643?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/45b3ab4436b4763e1890ded0728137de95df699d?src=pr&el=desc) will **increase** coverage by `8.24%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2643?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2643 +/- ##
===========================================
+ Coverage 54.95% 63.2% +8.24%
===========================================
Files 571 573 +2
Lines 25510 25591 +81
Branches 4532 4523 -9
===========================================
+ Hits 14019 16174 +2155
+ Misses 9393 7270 -2123
- Partials 2098 2147 +49
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2643?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/dubbo/remoting/transport/netty/NettyClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2643/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNsaWVudC5qYXZh) | `72.88% <0%> (-8.48%)` | `0% <0%> (-13%)` | |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2643/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==) | `79.31% <0%> (-6.9%)` | `0% <0%> (-11%)` | |
| [...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2643/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0Z1dHVyZUFkYXB0ZXIuamF2YQ==) | `58.06% <0%> (-6.46%)` | `0% <0%> (-3%)` | |
| [...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2643/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQWN0aXZlTGltaXRGaWx0ZXIuamF2YQ==) | `83.33% <0%> (-5.56%)` | `0% <0%> (-7%)` | |
| [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2643/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NoYW5uZWxXcmFwcGVkSW52b2tlci5qYXZh) | `41.66% <0%> (-4.17%)` | `0% <0%> (-3%)` | |
| [...he/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2643/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eVNlcnZlci5qYXZh) | `67.85% <0%> (-3.58%)` | `0% <0%> (-9%)` | |
| [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2643/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNvZGVjQWRhcHRlci5qYXZh) | `53.12% <0%> (-1.57%)` | `0% <0%> (-3%)` | |
| [...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2643/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NhbGxiYWNrU2VydmljZUNvZGVjLmphdmE=) | `77.2% <0%> (-1.48%)` | `0% <0%> (-29%)` | |
| [...n/java/org/apache/dubbo/config/ConsumerConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2643/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25zdW1lckNvbmZpZy5qYXZh) | `92.3% <0%> (ø)` | `0% <0%> (-15%)` | :arrow_down: |
| [...n/java/org/apache/dubbo/metrics/MetricManager.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2643/diff?src=pr&el=tree#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9NZXRyaWNNYW5hZ2VyLmphdmE=) | | | |
| ... and [173 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2643/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2643?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2643?src=pr&el=footer). Last update [45b3ab4...c44cb33](https://codecov.io/gh/apache/incubator-dubbo/pull/2643?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2643 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org