You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/05/29 15:47:05 UTC

[GitHub] [incubator-pekko] pjfanning opened a new issue, #362: possible need to include scala-java8-compat in LICENSE/NOTICE

pjfanning opened a new issue, #362:
URL: https://github.com/apache/incubator-pekko/issues/362

   Some recent refactors have seen us make scala-java8-compat a dependency for Scala 2.12 only.
   
   We need to analyse whether any code was copied into Pekko from scala-java8-compat and update our LICENSE and NOTICE files accordingly.
   
   * https://github.com/apache/incubator-pekko/blob/main/LICENSE
   * https://github.com/apache/incubator-pekko/blob/main/NOTICE
   
   @mdedetrich could you confirm if this is needed - I can do a PR if one is needed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] mdedetrich commented on issue #362: possible need to include scala-java8-compat in LICENSE/NOTICE

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.

mdedetrich commented on issue #362:
URL: https://github.com/apache/incubator-pekko/issues/362#issuecomment-1568671027

   Okay so I had a proper look into this including other converter functions which are not explicitly mentioned in this issue (I think its useful to tackle this properly at once)
   
   * `FutureConverters`: This shouldn't require any adjustment to `LICENSE`/`NOTICE`/headers because there is no copied code, its just a wrapper that forwards function calls to the actual implementation which is a standard jar dependency
   * `OptionConverters`: This is the same as `FutureConverters` but there is one "technically" correct exception which is https://github.com/apache/incubator-pekko/blob/898c69701b7783e6da9e69321ca345ea98ddc86b/actor/src/main/scala-2.12/org/apache/pekko/util/OptionConverters.scala#L28-L37. The reason why I state this is "technically" correct is that while its true that the code is the same (not exactly lexically but the compiled meaning of the code is the same) its basically impossible to come up with an alternative implementation since its so trivial (to drive this point further, this is about as trivial as asking someone how to add two numbers, 99% of people would write it as `a + b`). IANAL statement here, I am not going to make a call whether we should make a legal understanding of this, I just want to be clear about how benign/trivial the code is.
   * `FunctionConverters`: Same as `FutureConverters`, its just forwarder functions, i.e. no copying of code.
   * `ccompat` ergo collection compat: This is the one area where code was literally copied from `scala-collections-compat`. I guess that due to this we should should also copy the header over (i.e. https://github.com/scala/scala-collection-compat/blob/main/compat/src/main/scala-2.11_2.12/scala/collection/compat/BuildFrom.scala#L1-L11) and mention it in `LICENSE`/`NOTICE`.
   
   @pjfanning Let me know if this answers your questions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] justinmclean commented on issue #362: possible need to include scala-java8-compat in LICENSE/NOTICE

Posted by "justinmclean (via GitHub)" <gi...@apache.org>.

justinmclean commented on issue #362:
URL: https://github.com/apache/incubator-pekko/issues/362#issuecomment-1569361839

   "ergo collection compat: This is the one area where code was literally copied from scala-collections-compat"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] mdedetrich commented on issue #362: possible need to include scala-java8-compat in LICENSE/NOTICE

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.

mdedetrich commented on issue #362:
URL: https://github.com/apache/incubator-pekko/issues/362#issuecomment-1567317022

   I'll check this properly tomorrow 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org