You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by am...@apache.org on 2021/05/02 17:38:57 UTC

[superset] branch feat/group_by_adhoc_filters created (now 404087e)

This is an automated email from the ASF dual-hosted git repository.

amitmiran pushed a change to branch feat/group_by_adhoc_filters
in repository https://gitbox.apache.org/repos/asf/superset.git.


      at 404087e  feat(native-filters): group by with adhoc filters

This branch includes the following new commits:

     new 404087e  feat(native-filters): group by with adhoc filters

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


[superset] 01/01: feat(native-filters): group by with adhoc filters

Posted by am...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

amitmiran pushed a commit to branch feat/group_by_adhoc_filters
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 404087edb1331f53eb547d7d660e20f988c42a5c
Author: Amit Miran <47...@users.noreply.github.com>
AuthorDate: Sun May 2 20:37:45 2021 +0300

    feat(native-filters): group by with adhoc filters
---
 .../FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
index 2eca4e8..659a2fe 100644
--- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
+++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
@@ -109,7 +109,7 @@ const FILTERS_WITHOUT_COLUMN = [
   'filter_timecolumn',
   'filter_groupby',
 ];
-const FILTERS_WITH_ADHOC_FILTERS = ['filter_select', 'filter_range'];
+const FILTERS_WITH_ADHOC_FILTERS = ['filter_select', 'filter_range', 'filter_groupby'];
 
 /**
  * The configuration form for a specific filter.