You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2015/12/31 08:21:22 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-547: Cannot select outpu...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/585
ZEPPELIN-547: Cannot select output of the paragraph
### What is this PR for?
Cannot select error/output of the paragraph.
Whenever there is a click on output the focus is set to editor.
### What type of PR is it?
[Bug Fix]
### Todos
* [x] - keep scope for mouse drag, doulble/multiple clicks
### Is there a relevant Jira issue?
[ZEPPELIN-547](https://issues.apache.org/jira/browse/ZEPPELIN-547)
### How should this be tested?
- Try single click on output, focus should be set to editor.
- but if there is a mouse drag or double/triple click on output, it should select output.
### Screenshots (if appropriate)
Single click, double click, triple click
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/incubator-zeppelin ZEPPELIN-547
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/585.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #585
----
commit 7e79a7581314f1bba3480c13c41d8c2af453f20a
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2015-12-31T07:05:57Z
keep scope for mouse drag, doulble/multiple clicks
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-547: Cannot select outpu...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/585#issuecomment-168268821
@prabhjyotsingh please take a look https://github.com/prabhjyotsingh/incubator-zeppelin/pull/1. I think more simple patch is possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-547: Cannot select outpu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/585
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-547: Cannot select outpu...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/585#issuecomment-168354732
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-547: Cannot select outpu...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/585#issuecomment-168317245
Thanks for fix for the bug.
LGTM and merge if there're no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---