Re: [PR] [#713] feat(Java): PropertyGroup filtering [incubator-graphar]

["yangxk1 (via GitHub)" <gi...@apache.org>]

yangxk1 commented on PR #713:
URL: https://github.com/apache/incubator-graphar/pull/713#issuecomment-3017684669

   Thanks for the PR — the `version` support you added is really useful!
   
   I just wanted to clarify one thing:
   I think my earlier explanation wasn't very clear. "property filtering", I meant filtering properties during data reading using predicate pushdown, e.g., reading only certain properties from Parquet/CSV/ORC files.
   
   some small suggestions:
   - Could `getVersion()` return `InfoVersion` directly?
   - I think it would make sense to move `InfoVersion` out of `VersionParser`, as it's part of the public API, but `VersionParser` is more of a tool class.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org