You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2019/01/03 19:34:48 UTC
[GitHub] codecov-io edited a comment on issue #3633: Use
ZkCacheBaseDataAccessor to cache instance configs in
PinotHelixResourceManager
codecov-io edited a comment on issue #3633: Use ZkCacheBaseDataAccessor to cache instance configs in PinotHelixResourceManager
URL: https://github.com/apache/incubator-pinot/pull/3633#issuecomment-451033315
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3633?src=pr&el=h1) Report
> Merging [#3633](https://codecov.io/gh/apache/incubator-pinot/pull/3633?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/24897f683e7f28e1626b6989ada5e16eb7bc3cca?src=pr&el=desc) will **increase** coverage by `0.28%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/3633?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3633 +/- ##
============================================
+ Coverage 70.68% 70.96% +0.28%
Complexity 4 4
============================================
Files 1012 1012
Lines 46454 46465 +11
Branches 6212 6213 +1
============================================
+ Hits 32838 32976 +138
+ Misses 11461 11318 -143
- Partials 2155 2171 +16
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3633?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ntroller/helix/core/PinotHelixResourceManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3633/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvUGlub3RIZWxpeFJlc291cmNlTWFuYWdlci5qYXZh) | `60.1% <66.66%> (+0.14%)` | `0 <0> (ø)` | :arrow_down: |
| [...in/pinot/core/query/pruner/ValidSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/3633/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3F1ZXJ5L3BydW5lci9WYWxpZFNlZ21lbnRQcnVuZXIuamF2YQ==) | `57.14% <0%> (-28.58%)` | `0% <0%> (ø)` | |
| [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3633/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9GbG9hdE9uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `80% <0%> (-13.34%)` | `0% <0%> (ø)` | |
| [...impl/dictionary/FloatOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3633/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9GbG9hdE9mZkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `81.81% <0%> (-10.91%)` | `0% <0%> (ø)` | |
| [...e/operator/dociditerators/MVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3633/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2RvY2lkaXRlcmF0b3JzL01WU2NhbkRvY0lkSXRlcmF0b3IuamF2YQ==) | `60.6% <0%> (-6.07%)` | `0% <0%> (ø)` | |
| [.../impl/dictionary/BaseOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3633/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9CYXNlT2ZmSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `81.03% <0%> (-2.88%)` | `0% <0%> (ø)` | |
| [...n/pinot/controller/helix/SegmentStatusChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/3633/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L1NlZ21lbnRTdGF0dXNDaGVja2VyLmphdmE=) | `86.71% <0%> (-2.35%)` | `0% <0%> (ø)` | |
| [.../pinot/core/data/manager/BaseTableDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3633/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2RhdGEvbWFuYWdlci9CYXNlVGFibGVEYXRhTWFuYWdlci5qYXZh) | `92.59% <0%> (-1.24%)` | `0% <0%> (ø)` | |
| [...ot/core/query/pruner/ColumnValueSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/3633/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3F1ZXJ5L3BydW5lci9Db2x1bW5WYWx1ZVNlZ21lbnRQcnVuZXIuamF2YQ==) | `87.32% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [21 more](https://codecov.io/gh/apache/incubator-pinot/pull/3633/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3633?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3633?src=pr&el=footer). Last update [24897f6...c409eff](https://codecov.io/gh/apache/incubator-pinot/pull/3633?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org