You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by ottobackwards <gi...@git.apache.org> on 2018/05/21 16:47:47 UTC
[GitHub] nifi pull request #2727: NIFI-5220 add aws abstract processor validation for...
GitHub user ottobackwards opened a pull request:
https://github.com/apache/nifi/pull/2727
NIFI-5220 add aws abstract processor validation for proxy host and password, and tests
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [-] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [-] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [-] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [-] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [-] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ottobackwards/nifi fix-aws-validate-proxy
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2727.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2727
----
commit a712dfac5f0295703acb46e5decfd8a0315ad205
Author: Otto Fowler <ot...@...>
Date: 2018-05-21T16:16:17Z
add validation for host and password, and tests
----
---
[GitHub] nifi issue #2727: NIFI-5220 add aws abstract processor validation for proxy ...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2727
@MikeThomsen @ijokarumawak
---
[GitHub] nifi pull request #2727: NIFI-5220 add aws abstract processor validation for...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2727
---
[GitHub] nifi issue #2727: NIFI-5220 add aws abstract processor validation for proxy ...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2727
@ottobackwards Thanks for hardening the validation, LGTM +1. Merging.
---