You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/19 14:02:00 UTC

[jira] [Commented] (ARTEMIS-1566) Openwire client can't receive compressed messages

    [ https://issues.apache.org/jira/browse/ARTEMIS-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296830#comment-16296830 ] 

ASF GitHub Bot commented on ARTEMIS-1566:
-----------------------------------------

GitHub user gaohoward opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1729

    ARTEMIS-1566 Openwire client can't receive compressed messages

    When openwire client uses compressed option to send messages
    (jms.useCompression=true) openwire client failed to receive them.
    The reason is in OpenwireMessageConverter.toAMQMessage():
    
    1. message.setContent() should be called after setting properties
     (It will cause the compressed content to decompressed before delivering to clients)
    2. message.onSend() should not be called here (it should be used
    by producers. If used here it changes the internal flags of the
    message and cause receive to fail).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gaohoward/activemq-artemis fm_943

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1729.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1729
    
----
commit 121de284d251cf332a98eb8d078ef6e1fd62cf0c
Author: Howard Gao <ho...@gmail.com>
Date:   2017-12-19T13:15:05Z

    ARTEMIS-1566 Openwire client can't receive compressed messages
    
    When openwire client uses compressed option to send messages
    (jms.useCompression=true) openwire client failed to receive them.
    The reason is in OpenwireMessageConverter.toAMQMessage():
    
    1. message.setContent() should be called after setting properties
     (It will cause the compressed content to decompressed before delivering to clients)
    2. message.onSend() should not be called here (it should be used
    by producers. If used here it changes the internal flags of the
    message and cause receive to fail).

----


> Openwire client can't receive compressed messages
> -------------------------------------------------
>
>                 Key: ARTEMIS-1566
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1566
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: OpenWire
>    Affects Versions: 2.4.0
>            Reporter: Howard Gao
>            Assignee: Howard Gao
>             Fix For: 2.5.0
>
>
> When openwire client uses compressed option to send messages (jms.useCompression=true) openwire client failed to receive them. The reason is in OpenwireMessageConverter.toAMQMessage():
> 1. message.setContent() should be called after setting properties (It will cause the compressed content to decompressed before delivering to clients)
> 2. message.onSend() should not be called here (it should be used by producers. If used here it changes the internal flags of the message and cause receive to fail).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)