You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by Stefan Seelmann <se...@apache.org> on 2010/06/06 20:01:34 UTC
Re: svn commit: r951912 - in /directory/apacheds/trunk: protocol-ntp/src/test/java/org/apache/directory/server/ntp/NtpITest.java
server-xml/ xbean-spring/
elecharny@apache.org wrote:
> Author: elecharny
> Date: Sun Jun 6 17:39:55 2010
> New Revision: 951912
>
> URL: http://svn.apache.org/viewvc?rev=951912&view=rev
> Log:
> Removed the server-xml and xbeans-spring modules
>
> Removed:
> directory/apacheds/trunk/server-xml/
> directory/apacheds/trunk/xbean-spring/
> Modified:
> directory/apacheds/trunk/protocol-ntp/src/test/java/org/apache/directory/server/ntp/NtpITest.java
>
> Modified: directory/apacheds/trunk/protocol-ntp/src/test/java/org/apache/directory/server/ntp/NtpITest.java
> URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-ntp/src/test/java/org/apache/directory/server/ntp/NtpITest.java?rev=951912&r1=951911&r2=951912&view=diff
> ==============================================================================
> --- directory/apacheds/trunk/protocol-ntp/src/test/java/org/apache/directory/server/ntp/NtpITest.java (original)
> +++ directory/apacheds/trunk/protocol-ntp/src/test/java/org/apache/directory/server/ntp/NtpITest.java Sun Jun 6 17:39:55 2010
> @@ -33,6 +33,7 @@ import org.apache.mina.filter.executor.E
> import org.apache.mina.util.AvailablePortFinder;
> import org.junit.After;
> import org.junit.Before;
> +import org.junit.Ignore;
> import org.junit.Test;
>
>
> @@ -74,6 +75,7 @@ public class NtpITest
> * @throws Exception if there are errors
> */
> @Test
> + @Ignore
> public void testNtp() throws Exception
> {
> InetAddress host = InetAddress.getByName( null );
>
Is this intended? I though I fixed this test yesterday, is it still failing?
Re: svn commit: r951912 - in /directory/apacheds/trunk: protocol-ntp/src/test/java/org/apache/directory/server/ntp/NtpITest.java
server-xml/ xbean-spring/
Posted by Emmanuel Lecharny <el...@gmail.com>.
On 6/6/10 8:17 PM, Stefan Seelmann wrote:
> Emmanuel Lecharny wrote:
>
>> On 6/6/10 8:01 PM, Stefan Seelmann wrote:
>>
>>>
>>>> @@ -74,6 +75,7 @@ public class NtpITest
>>>> * @throws Exception if there are errors
>>>> */
>>>> @Test
>>>> + @Ignore
>>>> public void testNtp() throws Exception
>>>> {
>>>> InetAddress host = InetAddress.getByName( null );
>>>>
>>>>
>>>>
>>> Is this intended? I though I fixed this test yesterday, is it still
>>> failing?
>>>
>>>
>> No, sorry, it was caught in a big commit I did. I will revert it
>> immediately.
>>
>> Btw, what was the problem ?--
>>
> The test asserted two things:
>
> - the delay is in range 0..1000 ms, both bounds excluded. But the delay
> could be 0, especially when getting the time from localhost without any
> network roundtrip. So I included the 0 as valid value.
>
> - the offset is in range 0..1000 ms, both bounds excluded. But the
> offset can be negative. Now the test checks that offset is in range
> -1000..1000 ms.
>
Doh...
yeah, smart. I didn't thought it can be such a simple problem...
Thank for the fix Stefan !
--
Regards,
Cordialement,
Emmanuel Lécharny
www.nextury.com
Re: svn commit: r951912 - in /directory/apacheds/trunk: protocol-ntp/src/test/java/org/apache/directory/server/ntp/NtpITest.java
server-xml/ xbean-spring/
Posted by Stefan Seelmann <se...@apache.org>.
Emmanuel Lecharny wrote:
> On 6/6/10 8:01 PM, Stefan Seelmann wrote:
>>
>>>
>>> @@ -74,6 +75,7 @@ public class NtpITest
>>> * @throws Exception if there are errors
>>> */
>>> @Test
>>> + @Ignore
>>> public void testNtp() throws Exception
>>> {
>>> InetAddress host = InetAddress.getByName( null );
>>>
>>>
>> Is this intended? I though I fixed this test yesterday, is it still
>> failing?
>>
> No, sorry, it was caught in a big commit I did. I will revert it
> immediately.
>
> Btw, what was the problem ?--
The test asserted two things:
- the delay is in range 0..1000 ms, both bounds excluded. But the delay
could be 0, especially when getting the time from localhost without any
network roundtrip. So I included the 0 as valid value.
- the offset is in range 0..1000 ms, both bounds excluded. But the
offset can be negative. Now the test checks that offset is in range
-1000..1000 ms.
Kind Regards,
Stefan
Re: svn commit: r951912 - in /directory/apacheds/trunk: protocol-ntp/src/test/java/org/apache/directory/server/ntp/NtpITest.java
server-xml/ xbean-spring/
Posted by Emmanuel Lecharny <el...@gmail.com>.
On 6/6/10 8:01 PM, Stefan Seelmann wrote:
>
>>
>> @@ -74,6 +75,7 @@ public class NtpITest
>> * @throws Exception if there are errors
>> */
>> @Test
>> + @Ignore
>> public void testNtp() throws Exception
>> {
>> InetAddress host = InetAddress.getByName( null );
>>
>>
> Is this intended? I though I fixed this test yesterday, is it still failing?
>
No, sorry, it was caught in a big commit I did. I will revert it
immediately.
Btw, what was the problem ?--
Regards,
Cordialement,
Emmanuel Lécharny
www.nextury.com