You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/11/01 02:58:00 UTC
[GitHub] [rocketmq-clients] aaron-ai opened a new pull request, #272: Define index of LoadBalancer as static
aaron-ai opened a new pull request, #272:
URL: https://github.com/apache/rocketmq-clients/pull/272
There is no need to generate index in constructor of load balancer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] codecov-commenter commented on pull request #272: Define index of LoadBalancer as static
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #272:
URL: https://github.com/apache/rocketmq-clients/pull/272#issuecomment-1297955409
# [Codecov](https://codecov.io/gh/apache/rocketmq-clients/pull/272?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#272](https://codecov.io/gh/apache/rocketmq-clients/pull/272?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cae96d8) into [master](https://codecov.io/gh/apache/rocketmq-clients/commit/2c9b67ddf74de9d31d1d16b5449e71a37c463b3c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2c9b67d) will **increase** coverage by `0.04%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## master #272 +/- ##
============================================
+ Coverage 35.99% 36.03% +0.04%
- Complexity 670 671 +1
============================================
Files 220 220
Lines 11232 11232
Branches 275 275
============================================
+ Hits 4043 4048 +5
+ Misses 6934 6928 -6
- Partials 255 256 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| java | `62.72% <50.00%> (+0.13%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-clients/pull/272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...t/java/impl/consumer/SubscriptionLoadBalancer.java](https://codecov.io/gh/apache/rocketmq-clients/pull/272/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvY29uc3VtZXIvU3Vic2NyaXB0aW9uTG9hZEJhbGFuY2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ent/java/impl/producer/PublishingLoadBalancer.java](https://codecov.io/gh/apache/rocketmq-clients/pull/272/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvcHJvZHVjZXIvUHVibGlzaGluZ0xvYWRCYWxhbmNlci5qYXZh) | `65.11% <100.00%> (ø)` | |
| [...g/apache/rocketmq/client/java/impl/ClientImpl.java](https://codecov.io/gh/apache/rocketmq-clients/pull/272/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvQ2xpZW50SW1wbC5qYXZh) | `55.44% <0.00%> (+1.60%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] aaron-ai merged pull request #272: Define index of LoadBalancer as static
Posted by GitBox <gi...@apache.org>.
aaron-ai merged PR #272:
URL: https://github.com/apache/rocketmq-clients/pull/272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org