You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/02/19 14:20:00 UTC
[jira] [Commented] (DRILL-7592) Add missing licenses and update
plugins exclusion list
[ https://issues.apache.org/jira/browse/DRILL-7592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040085#comment-17040085 ]
ASF GitHub Bot commented on DRILL-7592:
---------------------------------------
vvysotskyi commented on pull request #1989: DRILL-7592: Add missing licenses and update plugins exclusion list
URL: https://github.com/apache/drill/pull/1989
# [DRILL-7592](https://issues.apache.org/jira/browse/DRILL-7592): Add missing licenses and update plugins exclusion list
## Description
Updated list of files to check, updated their license.
## Documentation
NA
## Testing
Checked that both rat and license-maven-plugin checks are passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Add missing licenses and update plugins exclusion list
> ------------------------------------------------------
>
> Key: DRILL-7592
> URL: https://issues.apache.org/jira/browse/DRILL-7592
> Project: Apache Drill
> Issue Type: Task
> Reporter: Vova Vysotskyi
> Assignee: Vova Vysotskyi
> Priority: Major
> Fix For: 1.18.0
>
>
> The project contains a lot of files without licenses, like this one: [https://github.com/apache/drill/blob/f2654eed3b6d444280b5c0c2a507edc355c676e6/contrib/format-excel/src/main/resources/drill-module.conf].
> Besides {{*.conf}} files, there are other file types that may and should contain license.
> Except for adding licenses, some binary files should be excluded from the check to avoid warnings like this one:
> {noformat}
> [INFO] --- license-maven-plugin:3.0:check (default) @ drill-root ---
> [INFO] Checking licenses...
> [WARNING] Unknown file extension: /home/runner/work/drill/drill/contrib/format-esri/src/test/resources/shapefiles/CA-cities.shp
> [WARNING] Unknown file extension: /home/runner/work/drill/drill/contrib/format-esri/src/test/resources/shapefiles/CA-cities.prj
> [WARNING] Unknown file extension: /home/runner/work/drill/drill/contrib/format-esri/src/test/resources/shapefiles/CA-cities.dbf
> [WARNING] Unknown file extension: /home/runner/work/drill/drill/contrib/storage-hive/core/src/test/resources/complex_types/map/map_union_tbl.avro
> [WARNING] Unknown file extension: /home/runner/work/drill/drill/exec/java-exec/src/test/resources/avro/map_string_to_long.avro
> [WARNING] Unknown file extension: /home/runner/work/drill/drill/exec/java-exec/src/test/resources/regex/firewall.ssdlog
> [WARNING] Unable to find a comment style definition for some files. You may want to add a custom mapping for the relevant file extensions.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)