[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4157: [TE] Dynamically change H2 demo database timestamps

[GitBox <gi...@apache.org>]

jihaozh commented on a change in pull request #4157: [TE] Dynamically change H2 demo database timestamps
URL: https://github.com/apache/incubator-pinot/pull/4157#discussion_r277853825
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datasource/sql/SqlResponseCacheLoader.java
 ##########
 @@ -164,6 +164,10 @@ public SqlResponseCacheLoader(Map<String, Object> properties) throws Exception {
             SqlUtils.createTable(h2DataSource, tableName, dataset.getTimeColumn(), metrics, dataset.getDimensions());
             SqlUtils.onBoardSqlDataset(dataset);
 
+            List<H2Row> h2Rows = new ArrayList<>();
+            DateTime maxDateTime = DateTime.parse("1970-01-01");
 
 Review comment:
   Make the maxDateTime static final 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org