[jira] [Commented] (TS-4302) Compiler warnings on OmniOS w. gcc 5.1

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224005#comment-15224005 ] 

ASF GitHub Bot commented on TS-4302:
------------------------------------

GitHub user zwoop opened a pull request:

    https://github.com/apache/trafficserver/pull/548

    TS-4302 Adds more control over the event API to use

    This also addresses the build problems on current Illumos, by prioritizing the ports interface. But as such, it can now be useful to allow overriding this, with an explicit configure option (since Illumos now supports both epoll and ports).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zwoop/trafficserver TS-4302

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/548.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #548
    
----
commit 07b08bf1d93730ccd2f6e5d0fe73a117a06bd815
Author: Leif Hedstrom <zw...@apache.org>
Date:   2016-03-31T14:23:26Z

    TS-4302 Adds more control over the event API to use

----


> Compiler warnings on OmniOS w. gcc 5.1
> --------------------------------------
>
>                 Key: TS-4302
>                 URL: https://issues.apache.org/jira/browse/TS-4302
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Build, Core
>            Reporter: Leif Hedstrom
>            Assignee: Leif Hedstrom
>            Priority: Blocker
>             Fix For: 6.2.0
>
>
> Getting these warnings from gcc 5.1:
> {code}
> In file included from /home/leif/apache/trafficserver.git/iocore/net/P_Net.h:94:0,
>                  from /home/leif/apache/trafficserver.git/proxy/InkAPIInternal.h:29,
>                  from /home/leif/apache/trafficserver.git/mgmt/ProcessManager.cc:28:
> /home/leif/apache/trafficserver.git/iocore/net/P_UnixNet.h: In function ‘void read_disable(NetHandler*, UnixNetVConnection*)’:
> /home/leif/apache/trafficserver.git/iocore/net/P_UnixNet.h:424:30: warning: overflow in implicit constant conversion [-Woverflow]
>    vc->ep.modify(-EVENTIO_READ);
>                               ^
> /home/leif/apache/trafficserver.git/iocore/net/P_UnixNet.h: In function ‘void write_disable(NetHandler*, UnixNetVConnection*)’:
> /home/leif/apache/trafficserver.git/iocore/net/P_UnixNet.h:445:31: warning: overflow in implicit constant conversion [-Woverflow]
>    vc->ep.modify(-EVENTIO_WRITE);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)