[jira] [Updated] (TS-4201) OneWayTunnel::connection_closed callback handleEvent with wrong continuation

["Leif Hedstrom (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TS-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leif Hedstrom updated TS-4201:
------------------------------
    Labels: review  (was: )

> OneWayTunnel::connection_closed callback handleEvent with wrong continuation
> ----------------------------------------------------------------------------
>
>                 Key: TS-4201
>                 URL: https://issues.apache.org/jira/browse/TS-4201
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Core, Utilities
>            Reporter: Oknet Xu
>              Labels: review
>
> the OneWayTunnel::connection_closed code below: 
> {code}
> void
> OneWayTunnel::connection_closed(int result)
> {
>   if (cont) {
> #ifdef TEST
>     cout << "OneWayTunnel::connection_closed() ... calling cont" << endl;
> #endif
>     cont->handleEvent(result ? VC_EVENT_ERROR : VC_EVENT_EOS, cont);
>   } else {
>     OneWayTunnel_free(this);
>   }
> }
> {code}
> {code}cont->handleEvent(result ? VC_EVENT_ERROR : VC_EVENT_EOS, cont);{code}
> It calls cont->handleEvent with `cont'.
> If `cont' is not NULL, the handleEvent will free this OneWayTunnel object.
> In order to free OneWayTunnel object, `cont' should be replaced by `this'.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)