You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/03/10 16:36:55 UTC
[GitHub] [samza] xinyuiscool commented on a change in pull request #1309:
SAMZA-2453: Update ClusterBasedJobCoordinator to support Beam jobs
xinyuiscool commented on a change in pull request #1309: SAMZA-2453: Update ClusterBasedJobCoordinator to support Beam jobs
URL: https://github.com/apache/samza/pull/1309#discussion_r390451505
##########
File path: samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
##########
@@ -634,4 +651,20 @@ static ClusterBasedJobCoordinator createFromConfigLoader(Config submissionConfig
metadataStore,
config);
}
+
+ @VisibleForTesting
+ static String[] toArgs(ApplicationConfig config) {
+ List<String> args = new ArrayList<>(config.size() * 2);
+
+ config.forEach((key, value) -> {
+ if (key.equals(ApplicationConfig.APP_MAIN_ARGS)) {
+ args.addAll(Arrays.asList(value.split("\\s")));
+ } else {
Review comment:
is there else part being used right now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services