[GitHub] [netbeans] lkishalmi commented on a change in pull request #3193: [NETBEANS-6065] Make Gradle Project test close connections to Gradle Daemon

[GitBox <gi...@apache.org>]

lkishalmi commented on a change in pull request #3193:
URL: https://github.com/apache/netbeans/pull/3193#discussion_r716245424



##########
File path: extide/gradle/test/unit/src/org/netbeans/modules/gradle/NbGradleProjectImplTest.java
##########
@@ -220,18 +244,18 @@ public void testIncreaseAimedQualityChangesProject() throws Exception {
      * the evaluated state does not exist.
      */
     public void testEvaluateTrustedDoesNotExecuteScript() throws Exception {
-        Project prj = createProject();
         NbGradleProject ngp = NbGradleProject.get(prj);
         ProjectTrust.getDefault().trustProject(prj);
         // initializes the project
         assertTrue(ngp.getQuality().worseThan(NbGradleProject.Quality.EVALUATED));
-        
+        assertHasNoConnection(prj);
         NbGradleProjectImpl prjImpl = prj.getLookup().lookup(NbGradleProjectImpl.class);
         GradleProject curProject = prjImpl.getGradleProject();
         prjImpl.setAimedQuality(Quality.EVALUATED);
         GradleProject newProject = prjImpl.getGradleProject();
         assertTrue(newProject.getQuality().worseThan(NbGradleProject.Quality.EVALUATED));
         assertSame(newProject, curProject);
+        assertHasNoConnection(prj);

Review comment:
       Well certain operation shall not create any connections. These are just checkpoints, to fail the test if that would ever happen.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists