You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/07/02 14:05:45 UTC
[GitHub] [inlong] GanfengTan opened a new pull request, #4844: [INLONG-4843][Manager] Add RPC URL for TubeMQ cluster
GanfengTan opened a new pull request, #4844:
URL: https://github.com/apache/inlong/pull/4844
Add Manager configuration parameters to Tube.
- Fixes #4843
### Motivation
Task configuration succeeded.
<img width="1652" alt="image" src="https://user-images.githubusercontent.com/17596132/177004029-c914a6ee-5f84-4501-bba9-589ea7fddf6f.png">
### Modifications
Add RPC Url
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] GanfengTan commented on a diff in pull request #4844: [INLONG-4843][Manager] Add RPC URL for TubeMQ cluster
Posted by GitBox <gi...@apache.org>.
GanfengTan commented on code in PR #4844:
URL: https://github.com/apache/inlong/pull/4844#discussion_r912374957
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/group/InlongGroupServiceImpl.java:
##########
@@ -355,8 +355,8 @@ public boolean updateAfterApprove(InlongGroupApproveRequest approveInfo, String
Preconditions.checkNotNull(approveInfo, "inlong approve request cannot be empty");
String groupId = approveInfo.getInlongGroupId();
Preconditions.checkNotNull(groupId, ErrorCodeEnum.GROUP_ID_IS_EMPTY.getMessage());
- String mqType = approveInfo.getMqType();
- Preconditions.checkNotNull(mqType, "MQ type cannot be empty");
+ // String mqType = approveInfo.getMqType();
Review Comment:
Has been modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #4844: [INLONG-4843][Manager] Add RPC URL for TubeMQ cluster
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4844:
URL: https://github.com/apache/inlong/pull/4844#discussion_r912370821
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/group/InlongGroupServiceImpl.java:
##########
@@ -355,8 +355,8 @@ public boolean updateAfterApprove(InlongGroupApproveRequest approveInfo, String
Preconditions.checkNotNull(approveInfo, "inlong approve request cannot be empty");
String groupId = approveInfo.getInlongGroupId();
Preconditions.checkNotNull(groupId, ErrorCodeEnum.GROUP_ID_IS_EMPTY.getMessage());
- String mqType = approveInfo.getMqType();
- Preconditions.checkNotNull(mqType, "MQ type cannot be empty");
+ // String mqType = approveInfo.getMqType();
Review Comment:
Why comment on those codes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow merged pull request #4844: [INLONG-4843][Manager] Add RPC URL for TubeMQ cluster
Posted by GitBox <gi...@apache.org>.
healchow merged PR #4844:
URL: https://github.com/apache/inlong/pull/4844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org