You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/09/16 11:16:50 UTC

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1457: ZOOKEEPER-3937: C client: avoid out-of-order packets during SASL negociation

eolivelli commented on a change in pull request #1457:
URL: https://github.com/apache/zookeeper/pull/1457#discussion_r489356880



##########
File path: zookeeper-client/zookeeper-client-c/src/zookeeper.c
##########
@@ -344,6 +344,38 @@ static int is_sasl_auth_in_progress(zhandle_t* zh)
 #endif /* HAVE_CYRUS_SASL_H */
 }
 
+/*
+ * Extract the type field (ZOO_*_OP) of a serialized RequestHeader.
+ *
+ * (This is not the most efficient way of fetching 4 bytes, but it is
+ * currently only used during SASL negociation.)

Review comment:
       typo: negociation  -> negotiation
   here and in other places




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org