You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/04/14 17:40:22 UTC
[Impala-ASF-CR] IMPALA-11974: Fix xrange, split in collect diagnostics.py
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19746
Change subject: IMPALA-11974: Fix xrange, split in collect_diagnostics.py
......................................................................
IMPALA-11974: Fix xrange, split in collect_diagnostics.py
Python3 deprecates xrange operator, this commit replaces it with the
range operator similar to earlier replacements in IMPALA-11974.
Adds decode() to command stdout before splitting. Popen returns bytes,
which in Python 2 supports split while in Python 3 split requires a str
object. In Python 2, decode converts bytes to unicode (which also
support split); in Python 3, decode converts bytes to str.
Testing:
- Tested that Python3 parses this file successfully
- Ran '$IMPALA_HOME/bin/diagnostics/collect_diagnostics.py --pid <pid>
--minidumps 2 1 --minidumps_dir $IMPALA_HOME/logs/cluster/minidumps'
and inspected the results.
Change-Id: I52f075825d47613293b106a7c50d4499c19cd3f4
---
M bin/diagnostics/collect_diagnostics.py
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/19746/1
--
To view, visit http://gerrit.cloudera.org:8080/19746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I52f075825d47613293b106a7c50d4499c19cd3f4
Gerrit-Change-Number: 19746
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11974: Fix xrange, split in collect diagnostics.py
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19746 )
Change subject: IMPALA-11974: Fix xrange, split in collect_diagnostics.py
......................................................................
Patch Set 1: Code-Review+1
LGTM, thank you for fixing it!
--
To view, visit http://gerrit.cloudera.org:8080/19746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52f075825d47613293b106a7c50d4499c19cd3f4
Gerrit-Change-Number: 19746
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Mon, 17 Apr 2023 08:20:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11974: Fix xrange, split in collect diagnostics.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19746 )
Change subject: IMPALA-11974: Fix xrange, split in collect_diagnostics.py
......................................................................
IMPALA-11974: Fix xrange, split in collect_diagnostics.py
Python3 deprecates xrange operator, this commit replaces it with the
range operator similar to earlier replacements in IMPALA-11974.
Adds universal_newlines to Popen so that we return text in Python 3.
Testing:
- Ran '$IMPALA_HOME/bin/diagnostics/collect_diagnostics.py --pid <pid>
--minidumps 2 1 --minidumps_dir $IMPALA_HOME/logs/cluster/minidumps
--stacks 2 1' with Python 2/3 and inspected the results.
Change-Id: I52f075825d47613293b106a7c50d4499c19cd3f4
Reviewed-on: http://gerrit.cloudera.org:8080/19746
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/diagnostics/collect_diagnostics.py
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I52f075825d47613293b106a7c50d4499c19cd3f4
Gerrit-Change-Number: 19746
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
[Impala-ASF-CR] IMPALA-11974: Fix xrange, split in collect diagnostics.py
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19746 )
Change subject: IMPALA-11974: Fix xrange, split in collect_diagnostics.py
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19746/1/bin/diagnostics/collect_diagnostics.py
File bin/diagnostics/collect_diagnostics.py:
http://gerrit.cloudera.org:8080/#/c/19746/1/bin/diagnostics/collect_diagnostics.py@177
PS1, Line 177: return len(cmd.stdout.decode('utf-8').split("\n")) - 1
Should Command's Popen call use universal_newlines?
--
To view, visit http://gerrit.cloudera.org:8080/19746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52f075825d47613293b106a7c50d4499c19cd3f4
Gerrit-Change-Number: 19746
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Fri, 14 Apr 2023 23:23:50 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11974: Fix xrange, split in collect diagnostics.py
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19746 )
Change subject: IMPALA-11974: Fix xrange, split in collect_diagnostics.py
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19746/1/bin/diagnostics/collect_diagnostics.py
File bin/diagnostics/collect_diagnostics.py:
http://gerrit.cloudera.org:8080/#/c/19746/1/bin/diagnostics/collect_diagnostics.py@177
PS1, Line 177: return len(cmd.stdout.decode('utf-8').split("\n")) - 1
> Should Command's Popen call use universal_newlines?
Yeah, it should. My first reading was that it was being used to write binary files, but looking back I think I misread that.
--
To view, visit http://gerrit.cloudera.org:8080/19746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52f075825d47613293b106a7c50d4499c19cd3f4
Gerrit-Change-Number: 19746
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Sat, 15 Apr 2023 04:28:32 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11974: Fix xrange, split in collect diagnostics.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19746 )
Change subject: IMPALA-11974: Fix xrange, split in collect_diagnostics.py
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52f075825d47613293b106a7c50d4499c19cd3f4
Gerrit-Change-Number: 19746
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Mon, 17 Apr 2023 21:54:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11974: Fix xrange, split in collect diagnostics.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19746 )
Change subject: IMPALA-11974: Fix xrange, split in collect_diagnostics.py
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12805/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52f075825d47613293b106a7c50d4499c19cd3f4
Gerrit-Change-Number: 19746
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Fri, 14 Apr 2023 18:01:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11974: Fix xrange, split in collect diagnostics.py
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Riza Suminto, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19746
to look at the new patch set (#2).
Change subject: IMPALA-11974: Fix xrange, split in collect_diagnostics.py
......................................................................
IMPALA-11974: Fix xrange, split in collect_diagnostics.py
Python3 deprecates xrange operator, this commit replaces it with the
range operator similar to earlier replacements in IMPALA-11974.
Adds universal_newlines to Popen so that we return text in Python 3.
Testing:
- Ran '$IMPALA_HOME/bin/diagnostics/collect_diagnostics.py --pid <pid>
--minidumps 2 1 --minidumps_dir $IMPALA_HOME/logs/cluster/minidumps
--stacks 2 1' with Python 2/3 and inspected the results.
Change-Id: I52f075825d47613293b106a7c50d4499c19cd3f4
---
M bin/diagnostics/collect_diagnostics.py
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/19746/2
--
To view, visit http://gerrit.cloudera.org:8080/19746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I52f075825d47613293b106a7c50d4499c19cd3f4
Gerrit-Change-Number: 19746
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
[Impala-ASF-CR] IMPALA-11974: Fix xrange, split in collect diagnostics.py
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19746 )
Change subject: IMPALA-11974: Fix xrange, split in collect_diagnostics.py
......................................................................
Patch Set 2: Code-Review+2
Thanks for fixing this
--
To view, visit http://gerrit.cloudera.org:8080/19746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52f075825d47613293b106a7c50d4499c19cd3f4
Gerrit-Change-Number: 19746
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Mon, 17 Apr 2023 16:17:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11974: Fix xrange, split in collect diagnostics.py
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19746 )
Change subject: IMPALA-11974: Fix xrange, split in collect_diagnostics.py
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19746/1/bin/diagnostics/collect_diagnostics.py
File bin/diagnostics/collect_diagnostics.py:
http://gerrit.cloudera.org:8080/#/c/19746/1/bin/diagnostics/collect_diagnostics.py@177
PS1, Line 177: return len(cmd.stdout.split("\n")) - 1
> It just doesn't matter because the only other place we use stdout is provid
Done
--
To view, visit http://gerrit.cloudera.org:8080/19746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52f075825d47613293b106a7c50d4499c19cd3f4
Gerrit-Change-Number: 19746
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Mon, 17 Apr 2023 15:50:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11974: Fix xrange, split in collect diagnostics.py
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19746 )
Change subject: IMPALA-11974: Fix xrange, split in collect_diagnostics.py
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19746/1/bin/diagnostics/collect_diagnostics.py
File bin/diagnostics/collect_diagnostics.py:
http://gerrit.cloudera.org:8080/#/c/19746/1/bin/diagnostics/collect_diagnostics.py@177
PS1, Line 177: return len(cmd.stdout.decode('utf-8').split("\n")) - 1
> Yeah, it should. My first reading was that it was being used to write binar
It just doesn't matter because the only other place we use stdout is providing a handle to write directly to a file.
--
To view, visit http://gerrit.cloudera.org:8080/19746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52f075825d47613293b106a7c50d4499c19cd3f4
Gerrit-Change-Number: 19746
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Mon, 17 Apr 2023 15:13:48 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11974: Fix xrange, split in collect diagnostics.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19746 )
Change subject: IMPALA-11974: Fix xrange, split in collect_diagnostics.py
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12810/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52f075825d47613293b106a7c50d4499c19cd3f4
Gerrit-Change-Number: 19746
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Mon, 17 Apr 2023 16:04:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11974: Fix xrange, split in collect diagnostics.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19746 )
Change subject: IMPALA-11974: Fix xrange, split in collect_diagnostics.py
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52f075825d47613293b106a7c50d4499c19cd3f4
Gerrit-Change-Number: 19746
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Mon, 17 Apr 2023 16:35:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11974: Fix xrange, split in collect diagnostics.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19746 )
Change subject: IMPALA-11974: Fix xrange, split in collect_diagnostics.py
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9231/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52f075825d47613293b106a7c50d4499c19cd3f4
Gerrit-Change-Number: 19746
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Mon, 17 Apr 2023 16:35:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11974: Fix xrange, split in collect diagnostics.py
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19746 )
Change subject: IMPALA-11974: Fix xrange, split in collect_diagnostics.py
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52f075825d47613293b106a7c50d4499c19cd3f4
Gerrit-Change-Number: 19746
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Fri, 14 Apr 2023 18:04:40 +0000
Gerrit-HasComments: No