[GitHub] [spark] jackylee-ch commented on a change in pull request #35763: [SPARK-38433][BUILD] change the shell code style with shellcheck

[GitBox <gi...@apache.org>]

jackylee-ch commented on a change in pull request #35763:
URL: https://github.com/apache/spark/pull/35763#discussion_r828633349



##########
File path: dev/create-release/release-build.sh
##########
@@ -341,8 +341,8 @@ if [[ "$1" == "package" ]]; then
   fi
 
   if [[ $PUBLISH_SCALA_2_12 = 1 ]]; then
-    echo "Packages to build: ${!BINARY_PKGS_ARGS[@]}"
-    for key in ${!BINARY_PKGS_ARGS[@]}; do
+    echo "Packages to build: ${!BINARY_PKGS_ARGS[*]}"
+    for key in "${!BINARY_PKGS_ARGS[@]}"; do

Review comment:
       It's ok to me, we can skip this rule.

##########
File path: dev/create-release/release-build.sh
##########
@@ -181,7 +181,7 @@ BASE_PROFILES="-Pmesos -Pyarn -Pkubernetes"
 
 PUBLISH_SCALA_2_13=1
 SCALA_2_13_PROFILES="-Pscala-2.13"
-if [[ $SPARK_VERSION < "3.2" ]]; then
+if [ "$(echo $SPARK_VERSION | awk -F "." '{if ($1 <= 3 && $2 < 2) print $1}')" ]; then

Review comment:
       There indeed has some proble here. `10.0` will not pass `$SPARK_VERSION < "3.2"`. The condition can be changed to `echo $SPARK_VERSION | awk -F "." '{if (($1 < 3) || ($1 == 3 && $2 < 2)) print $1}'`.
   Hm, maybe skip the check and leave waning comment here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org