You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/10/14 23:30:14 UTC
[kudu-CR] Improve pmem cmake discovery failure message
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4729
to review the following change.
Change subject: Improve pmem cmake discovery failure message
......................................................................
Improve pmem cmake discovery failure message
Change-Id: I51d447733b2dd20eb8fbc7e19dd17c44ead0fc82
---
M cmake_modules/FindPmem.cmake
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/4729/1
--
To view, visit http://gerrit.cloudera.org:8080/4729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I51d447733b2dd20eb8fbc7e19dd17c44ead0fc82
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] Improve pmem cmake discovery failure message
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Improve pmem cmake discovery failure message
......................................................................
Patch Set 1:
Patch is fine, but would you mind explaining the significance of the difference in your commit message? Cmake's output with/without the patch would help with that.
--
To view, visit http://gerrit.cloudera.org:8080/4729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I51d447733b2dd20eb8fbc7e19dd17c44ead0fc82
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No