[jira] [Commented] (HBASE-5241) Deletes should not mask Puts that come after it.

["Phabricator (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-5241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208077#comment-13208077 ] 

Phabricator commented on HBASE-5241:
------------------------------------

stack has commented on the revision "HBASE-5241 [jira] Deletes should not mask Puts that come after it.".

  Not sure I grok completely whats going on.  Where is the extra cost we pay in seeking?

  Good stuff Amit.

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java:74 This is ugly!
  src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java:189 This used to be compare to zero.  Was it wrong?
  src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java:195 Or, I suppose -1L now means what 0L used to?
  src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java:277 Why this change?
  src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java:845 We remove this assertions because delete behavior has changed?

REVISION DETAIL
  https://reviews.facebook.net/D1731

                
> Deletes should not mask Puts that come after it.
> ------------------------------------------------
>
>                 Key: HBASE-5241
>                 URL: https://issues.apache.org/jira/browse/HBASE-5241
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Amitanand Aiyer
>         Attachments: HBASE-5241.D1731.1.patch
>
>
> Suppose that we have a delete row, and then followed by the put. The delete row
> can mask the put, unless there was a major compaction in between.
> Now that we are flushing the memstoreTS to disk, along with the KVs, we should be able
> to differentiate whether or not the Put happened after the Delete and offer better 
> delete semantics.
> Couldn't find a pre-existing JIRA that already discusses this, so creating one.
> Seems related to https://issues.apache.org/jira/browse/HBASE-2406, but is not quite the same.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira