You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/11/26 23:41:10 UTC

[GitHub] jerrypeng commented on a change in pull request #3060: Make sure to properly count number of processed messages in python

jerrypeng commented on a change in pull request #3060: Make sure to properly count number of processed messages in python
URL: https://github.com/apache/pulsar/pull/3060#discussion_r236470807
 
 

 ##########
 File path: pulsar-functions/proto/src/main/proto/InstanceCommunication.proto
 ##########
 @@ -49,8 +48,6 @@ message FunctionStatus {
     // expressed in ms since epoch
     int64 lastInvocationTime = 13;
     string instanceId = 14;
-//    MetricsData metrics = 15 [deprecated=true];
 
 Review comment:
   lets leave the commented out defs so that we know which indices have been used in the past for backwards compatibility reasons

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services