You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2013/11/15 22:33:30 UTC

Review Request 15594: OutputOI need to be passed.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15594/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-5813
    https://issues.apache.org/jira/browse/HIVE-5813


Repository: hive


Description
-------

OutputOI need to be passed.


Diffs
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java 1541617 
  trunk/ql/src/test/queries/clientpositive/vector_left_outer_join.q PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/vector_left_outer_join.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/15594/diff/


Testing
-------

new test case added.


Thanks,

Ashutosh Chauhan


Re: Review Request 15594: OutputOI need to be passed.

Posted by Remus Rusanu <re...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15594/#review28991
-----------------------------------------------------------

Ship it!


- Remus Rusanu


On Nov. 15, 2013, 9:33 p.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15594/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2013, 9:33 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-5813
>     https://issues.apache.org/jira/browse/HIVE-5813
> 
> 
> Repository: hive
> 
> 
> Description
> -------
> 
> OutputOI need to be passed.
> 
> 
> Diffs
> -----
> 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java 1541617 
>   trunk/ql/src/test/queries/clientpositive/vector_left_outer_join.q PRE-CREATION 
>   trunk/ql/src/test/results/clientpositive/vector_left_outer_join.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/15594/diff/
> 
> 
> Testing
> -------
> 
> new test case added.
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>


Re: Review Request 15594: OutputOI need to be passed.

Posted by Eric Hanson <eh...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15594/#review28989
-----------------------------------------------------------

Ship it!


Ship It!

- Eric Hanson


On Nov. 15, 2013, 9:33 p.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15594/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2013, 9:33 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-5813
>     https://issues.apache.org/jira/browse/HIVE-5813
> 
> 
> Repository: hive
> 
> 
> Description
> -------
> 
> OutputOI need to be passed.
> 
> 
> Diffs
> -----
> 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java 1541617 
>   trunk/ql/src/test/queries/clientpositive/vector_left_outer_join.q PRE-CREATION 
>   trunk/ql/src/test/results/clientpositive/vector_left_outer_join.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/15594/diff/
> 
> 
> Testing
> -------
> 
> new test case added.
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>