You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/10/01 06:00:55 UTC
[GitHub] [tvm] lhez opened a new issue #9174: [Bug] [CPP RPC] custom_addr not properly quoted in JSON string
lhez opened a new issue #9174:
URL: https://github.com/apache/tvm/issues/9174
I happened to need `custom_addr` option in cpp rpc. However, `custom_addr_` does not seem properly quoted in the JSON string that is sent to the tracker, resulting in JSON parsing failure in the tracker.
In particular, there are 3 occurrences in `apps/cpp_rpc/rpc_tracker_client.h` - [line 88](https://github.com/apache/tvm/blob/main/apps/cpp_rpc/rpc_tracker_client.h#L88), [line 116](https://github.com/apache/tvm/blob/main/apps/cpp_rpc/rpc_tracker_client.h#L116) and [line 168](https://github.com/apache/tvm/blob/main/apps/cpp_rpc/rpc_tracker_client.h#L168).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on issue #9174: [Bug] [CPP RPC] custom_addr not properly quoted in JSON string
Posted by GitBox <gi...@apache.org>.
areusch commented on issue #9174:
URL: https://github.com/apache/tvm/issues/9174#issuecomment-940500616
@lhez please feel free to re-open if this is not fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] rkimball commented on issue #9174: [Bug] [CPP RPC] custom_addr not properly quoted in JSON string
Posted by GitBox <gi...@apache.org>.
rkimball commented on issue #9174:
URL: https://github.com/apache/tvm/issues/9174#issuecomment-933767531
Here is a quick fix https://github.com/apache/tvm/pull/9192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on issue #9174: [Bug] [CPP RPC] custom_addr not properly quoted in JSON string
Posted by GitBox <gi...@apache.org>.
areusch commented on issue #9174:
URL: https://github.com/apache/tvm/issues/9174#issuecomment-933752603
thanks for reporting @lhez, @rkimball will take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] rkimball edited a comment on issue #9174: [Bug] [CPP RPC] custom_addr not properly quoted in JSON string
Posted by GitBox <gi...@apache.org>.
rkimball edited a comment on issue #9174:
URL: https://github.com/apache/tvm/issues/9174#issuecomment-933752701
You are correct. We need to add \\" around the `custom_addr` since it is a string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] rkimball commented on issue #9174: [Bug] [CPP RPC] custom_addr not properly quoted in JSON string
Posted by GitBox <gi...@apache.org>.
rkimball commented on issue #9174:
URL: https://github.com/apache/tvm/issues/9174#issuecomment-933752701
You are correct. We need to add \" around the `custom_addr` since it is a string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch closed issue #9174: [Bug] [CPP RPC] custom_addr not properly quoted in JSON string
Posted by GitBox <gi...@apache.org>.
areusch closed issue #9174:
URL: https://github.com/apache/tvm/issues/9174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org