You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/08/04 09:50:22 UTC

[GitHub] [incubator-echarts] pissang edited a comment on pull request #12468: Fix: gauge chart legend color is incorrect

pissang edited a comment on pull request #12468:
URL: https://github.com/apache/incubator-echarts/pull/12468#issuecomment-668499728


   I think it's better to encode the color in the visual so legend can access it.
   
   Current change is too tricky and may cause unexpected issues in the further. For example, this `#000` color may be given by the `visualMap` component. In this case `itemStyleModel.get('color')` is also null.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org