You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/04 18:19:09 UTC
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#9081: [dashboard] Fix for dashboard edit modal, loading user list
etr2460 commented on a change in pull request #9081: [dashboard] Fix for dashboard edit modal, loading user list
URL: https://github.com/apache/incubator-superset/pull/9081#discussion_r374840016
##########
File path: superset/assets/src/dashboard/components/PropertiesModal.jsx
##########
@@ -203,24 +204,22 @@ class PropertiesModal extends React.PureComponent {
<label className="control-label" htmlFor="owners">
{t('Owners')}
</label>
- {userOptions && (
- <>
- <Select
- name="owners"
- multi
- isLoading={!userOptions}
- value={values.owners}
- options={userOptions || []}
- onChange={this.onOwnersChange}
- disabled={!isOwnersLoaded}
- />
- <p className="help-block">
- {t(
- 'Owners is a list of users who can alter the dashboard.',
- )}
- </p>
- </>
- )}
+ <>
Review comment:
i'm pretty sure this fragment is unneeded now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org