You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/24 06:12:33 UTC

[GitHub] [spark] weixiuli opened a new pull request #35645: [MINOR] Clean up an unnecessary variable

weixiuli opened a new pull request #35645:
URL: https://github.com/apache/spark/pull/35645


   
   ### What changes were proposed in this pull request?
   Clean up an unnecessary variable.
   ### Why are the changes needed?
   
   There is an unnecessary variable, we should clean up it.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Passed GA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #35645: [MINOR] Clean up an unnecessary variable

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #35645:
URL: https://github.com/apache/spark/pull/35645#issuecomment-1050916370


   Yeah at least within all of sql/ or something


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #35645: [MINOR] Clean up an unnecessary variable

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35645:
URL: https://github.com/apache/spark/pull/35645#issuecomment-1051391390


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] weixiuli commented on pull request #35645: [MINOR] Clean up an unnecessary variable

Posted by GitBox <gi...@apache.org>.
weixiuli commented on pull request #35645:
URL: https://github.com/apache/spark/pull/35645#issuecomment-1050686341


   > Can we find similar instances, and fix them in one go?
   
   It is the only place I found.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #35645: [MINOR] Clean up an unnecessary variable

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35645:
URL: https://github.com/apache/spark/pull/35645#issuecomment-1049546252


   Can we find similar instances, and fix them in one go?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen closed pull request #35645: [MINOR] Clean up an unnecessary variable

Posted by GitBox <gi...@apache.org>.
srowen closed pull request #35645:
URL: https://github.com/apache/spark/pull/35645


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #35645: [MINOR] Clean up an unnecessary variable

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #35645:
URL: https://github.com/apache/spark/pull/35645#issuecomment-1055503133


   Merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #35645: [MINOR] Clean up an unnecessary variable

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35645:
URL: https://github.com/apache/spark/pull/35645#issuecomment-1050778590


   IIRC, IntelliJ has an inspection for unused variables, etc. It would be great to find the same instances and fix them in batch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org