You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by ro...@apache.org on 2017/02/16 12:29:13 UTC
hadoop git commit: YARN-6200. Reverting since the same functionality
achieved by YARN-1623. Revert "YARN-5068. Expose scheduler queue to
application master. (Harish Jaiprakash via rohithsharmaks)"
Repository: hadoop
Updated Branches:
refs/heads/branch-2.8 4c47cb68e -> da944fe0f
YARN-6200. Reverting since the same functionality achieved by YARN-1623.
Revert "YARN-5068. Expose scheduler queue to application master. (Harish Jaiprakash via rohithsharmaks)"
This reverts commit f102c4f6c8b5a38f73e41282215e9bc38240eed8.
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/da944fe0
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/da944fe0
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/da944fe0
Branch: refs/heads/branch-2.8
Commit: da944fe0f44e2bb2cd63c65aaa79f7d28ca6313a
Parents: 4c47cb6
Author: Rohith Sharma K S <ro...@apache.org>
Authored: Thu Feb 16 17:54:37 2017 +0530
Committer: Rohith Sharma K S <ro...@apache.org>
Committed: Thu Feb 16 17:54:37 2017 +0530
----------------------------------------------------------------------
.../apache/hadoop/yarn/api/ApplicationConstants.java | 7 -------
.../server/resourcemanager/amlauncher/AMLauncher.java | 14 --------------
.../TestApplicationMasterLauncher.java | 5 -----
3 files changed, 26 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hadoop/blob/da944fe0/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationConstants.java
----------------------------------------------------------------------
diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationConstants.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationConstants.java
index ad526d6..b2d765a 100644
--- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationConstants.java
+++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationConstants.java
@@ -171,13 +171,6 @@ public interface ApplicationConstants {
LD_LIBRARY_PATH("LD_LIBRARY_PATH"),
/**
- * $YARN_RESOURCEMANAGER_APPLICATION_QUEUE
- * The queue into which the app was submitted/launched.
- */
- YARN_RESOURCEMANAGER_APPLICATION_QUEUE(
- "YARN_RESOURCEMANAGER_APPLICATION_QUEUE"),
-
- /**
* $HADOOP_CONF_DIR
* Final, non-modifiable.
*/
http://git-wip-us.apache.org/repos/asf/hadoop/blob/da944fe0/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/amlauncher/AMLauncher.java
----------------------------------------------------------------------
diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/amlauncher/AMLauncher.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/amlauncher/AMLauncher.java
index e513198..8b44bd9 100644
--- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/amlauncher/AMLauncher.java
+++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/amlauncher/AMLauncher.java
@@ -51,7 +51,6 @@ import org.apache.hadoop.yarn.api.records.ContainerId;
import org.apache.hadoop.yarn.api.records.ContainerLaunchContext;
import org.apache.hadoop.yarn.api.records.NodeId;
import org.apache.hadoop.yarn.client.NMProxy;
-import org.apache.hadoop.yarn.conf.YarnConfiguration;
import org.apache.hadoop.yarn.event.EventHandler;
import org.apache.hadoop.yarn.exceptions.YarnException;
import org.apache.hadoop.yarn.ipc.YarnRPC;
@@ -187,25 +186,12 @@ public class AMLauncher implements Runnable {
ContainerLaunchContext container =
applicationMasterContext.getAMContainerSpec();
- // Populate the current queue name in the environment variable.
- setupQueueNameEnv(container, applicationMasterContext);
-
// Finalize the container
setupTokens(container, containerID);
return container;
}
- private void setupQueueNameEnv(ContainerLaunchContext container,
- ApplicationSubmissionContext applicationMasterContext) {
- String queueName = applicationMasterContext.getQueue();
- if (queueName == null) {
- queueName = YarnConfiguration.DEFAULT_QUEUE_NAME;
- }
- container.getEnvironment().put(ApplicationConstants.Environment
- .YARN_RESOURCEMANAGER_APPLICATION_QUEUE.key(), queueName);
- }
-
@Private
@VisibleForTesting
protected void setupTokens(
http://git-wip-us.apache.org/repos/asf/hadoop/blob/da944fe0/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestApplicationMasterLauncher.java
----------------------------------------------------------------------
diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestApplicationMasterLauncher.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestApplicationMasterLauncher.java
index 99ad9f6..9e959235 100644
--- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestApplicationMasterLauncher.java
+++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestApplicationMasterLauncher.java
@@ -94,7 +94,6 @@ public class TestApplicationMasterLauncher {
String nmHostAtContainerManager = null;
long submitTimeAtContainerManager;
int maxAppAttempts;
- private String queueName;
@Override
public StartContainersResponse
@@ -124,8 +123,6 @@ public class TestApplicationMasterLauncher {
Long.parseLong(env.get(ApplicationConstants.APP_SUBMIT_TIME_ENV));
maxAppAttempts =
Integer.parseInt(env.get(ApplicationConstants.MAX_APP_ATTEMPTS_ENV));
- queueName = env.get(ApplicationConstants.Environment
- .YARN_RESOURCEMANAGER_APPLICATION_QUEUE.key());
return StartContainersResponse.newInstance(
new HashMap<String, ByteBuffer>(), new ArrayList<ContainerId>(),
new HashMap<ContainerId, SerializedException>());
@@ -194,8 +191,6 @@ public class TestApplicationMasterLauncher {
containerManager.nmHostAtContainerManager);
Assert.assertEquals(YarnConfiguration.DEFAULT_RM_AM_MAX_ATTEMPTS,
containerManager.maxAppAttempts);
- Assert.assertEquals(YarnConfiguration.DEFAULT_QUEUE_NAME,
- containerManager.queueName);
MockAM am = new MockAM(rm.getRMContext(), rm
.getApplicationMasterService(), appAttemptId);
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org