You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/04 08:15:49 UTC
[GitHub] [airflow] turbaszek opened a new pull request #10150: Do not use .format() in log messages
turbaszek opened a new pull request #10150:
URL: https://github.com/apache/airflow/pull/10150
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] madison-ookla commented on pull request #10150: Do not use .format() in log messages
Posted by GitBox <gi...@apache.org>.
madison-ookla commented on pull request #10150:
URL: https://github.com/apache/airflow/pull/10150#issuecomment-668694868
> Actually Pylint takes care of this, currently this files are ignored in pylint-todo:
>
> https://github.com/apache/airflow/blob/1bca31b541c9c39fb8e79131e1dd4a868b5122d4/scripts/ci/pylint_todo.txt#L4-L5
>
> and hence Pylint didn't catch it 😬
>
> The Pylint check that takes care of it is `logging-format-interpolation (W1202)` and `logging-not-lazy (W1201):`
Got it! 😄 That's awesome, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #10150: Do not use .format() in log messages
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #10150:
URL: https://github.com/apache/airflow/pull/10150
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on pull request #10150: Do not use .format() in log messages
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #10150:
URL: https://github.com/apache/airflow/pull/10150#issuecomment-668686698
> Would it make sense to add a pre-commit hook for something like this? Would it be possible with `py-grep`?
Actually Pylint takes care of this, currently this files are ignored in pylint-todo:
https://github.com/apache/airflow/blob/1bca31b541c9c39fb8e79131e1dd4a868b5122d4/scripts/ci/pylint_todo.txt#L4-L5
and hence Pylint didn't catch it 😬
The Pylint check that takes care of it is `logging-format-interpolation (W1202)` and `logging-not-lazy (W1201):`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] madison-ookla commented on pull request #10150: Do not use .format() in log messages
Posted by GitBox <gi...@apache.org>.
madison-ookla commented on pull request #10150:
URL: https://github.com/apache/airflow/pull/10150#issuecomment-668685083
Would it make sense to add a pre-commit hook for something like this? Would it be possible with `py-grep`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #10150: Do not use .format() in log messages
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #10150:
URL: https://github.com/apache/airflow/pull/10150#issuecomment-668686698
> Would it make sense to add a pre-commit hook for something like this? Would it be possible with `py-grep`?
Actually Pylint takes care of this, currently this files are ignored in pylint-todo:
https://github.com/apache/airflow/blob/1bca31b541c9c39fb8e79131e1dd4a868b5122d4/scripts/ci/pylint_todo.txt#L4-L5
and hence Pylint didn't catch it 😬
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org