You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streams.apache.org by steveblackmon <gi...@git.apache.org> on 2015/06/30 21:30:30 UTC
[GitHub] incubator-streams pull request: better null handling, removed unne...
GitHub user steveblackmon opened a pull request:
https://github.com/apache/incubator-streams/pull/237
better null handling, removed unnecessary clazz from signature
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/steveblackmon/incubator-streams STREAMS-343.2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-streams/pull/237.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #237
----
commit 741f870e1b959e802d3d416315883389f0099cbb
Author: Steve Blackmon (@steveblackmon) <sb...@apache.org>
Date: 2015-06-30T19:29:51Z
removed unnecessary clazz from signature
better null handling
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: better null handling, removed unne...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-streams/pull/237
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: better null handling, removed unne...
Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/237#discussion_r33706231
--- Diff: streams-util/src/main/java/org/apache/streams/util/SerializationUtil.java ---
@@ -49,7 +49,7 @@
* @param serialized
* @return
*/
- public static Object deserialize(byte[] serialized, Class clazz) {
+ public static Object deserialize(byte[] serialized) {
--- End diff --
Typically yes, but this is actually reverting to what it was in 0.2-incubating release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: better null handling, removed unne...
Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon commented on the pull request:
https://github.com/apache/incubator-streams/pull/237#issuecomment-117693121
no. CI is broken until infra resolves https://issues.apache.org/jira/browse/BUILDS-88
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: better null handling, removed unne...
Posted by eponvert <gi...@git.apache.org>.
Github user eponvert commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/237#discussion_r33614989
--- Diff: streams-util/src/main/java/org/apache/streams/util/SerializationUtil.java ---
@@ -49,7 +49,7 @@
* @param serialized
* @return
*/
- public static Object deserialize(byte[] serialized, Class clazz) {
+ public static Object deserialize(byte[] serialized) {
--- End diff --
Changing the signature of a public method. Consider providing an overloaded variant with the original signature for compatibility?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: better null handling, removed unne...
Posted by eponvert <gi...@git.apache.org>.
Github user eponvert commented on the pull request:
https://github.com/apache/incubator-streams/pull/237#issuecomment-117820517
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: better null handling, removed unne...
Posted by eponvert <gi...@git.apache.org>.
Github user eponvert commented on the pull request:
https://github.com/apache/incubator-streams/pull/237#issuecomment-117316689
Any concern about the Travis CI error?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---