You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Juergen Donnerstag <ju...@gmail.com> on 2009/04/09 20:38:48 UTC

objections against applying Eclipse cleanup?

I want to run a Eclipse cleanup on the 1.4 trunk source code. Not
quite unexpected, on my dry run a lot of files are affected. Mostly
formatting stuff, some missing @override, some unused variables etc.
Any objections against committing it?

Juergen

Re: objections against applying Eclipse cleanup?

Posted by Juergen Donnerstag <ju...@gmail.com>.
ups, I'll fix them

Re: objections against applying Eclipse cleanup?

Posted by Igor Vaynberg <ig...@gmail.com>.
go for it as long as you promise to fix things if they break :)

btw, one of your commits broke the build:

org.apache.wicket.util.license.ApacheLicenceHeaderTest
[11:07:00]: [org.apache.wicket.util.license.ApacheLicenceHeaderTest]
testLicenseHeaders
[11:07:00]: [testLicenseHeaders]
org.apache.wicket.util.license.JavaScriptLicenseHeaderHandler failed.
The following files(5) didn't have correct license header: NONE
/opt/teamcity-agent/work/fce3afb75835a103/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/yuiloader.js
NONE /opt/teamcity-agent/work/fce3afb75835a103/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/yuiloader-min.js
NONE /opt/teamcity-agent/work/fce3afb75835a103/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/yahoo/yahoo-min.js
NONE /opt/teamcity-agent/work/fce3afb75835a103/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/event/event-min.js
NONE /opt/teamcity-agent/work/fce3afb75835a103/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/dom/dom-min.js
[11:07:00]: [testLicenseHeaders] junit.framework.AssertionFailedError:
org.apache.wicket.util.license.JavaScriptLicenseHeaderHandler failed.
The following files(5) didn't have correct license header:
NONE /opt/teamcity-agent/work/fce3afb75835a103/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/yuiloader.js
NONE /opt/teamcity-agent/work/fce3afb75835a103/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/yuiloader-min.js
NONE /opt/teamcity-agent/work/fce3afb75835a103/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/yahoo/yahoo-min.js
NONE /opt/teamcity-agent/work/fce3afb75835a103/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/event/event-min.js
NONE /opt/teamcity-agent/work/fce3afb75835a103/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/dom/dom-min.js


-igor

On Thu, Apr 9, 2009 at 11:38 AM, Juergen Donnerstag
<ju...@gmail.com> wrote:
> I want to run a Eclipse cleanup on the 1.4 trunk source code. Not
> quite unexpected, on my dry run a lot of files are affected. Mostly
> formatting stuff, some missing @override, some unused variables etc.
> Any objections against committing it?
>
> Juergen
>