You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/10/25 05:25:02 UTC
[GitHub] [camel-k] tadayosi opened a new pull request #2714: chore(ci): update to golangci-lint 1.42.x and use golangci/golangci-lint-action
tadayosi opened a new pull request #2714:
URL: https://github.com/apache/camel-k/pull/2714
<!-- Description -->
* Change linters to allowlist approach (disable-all: true) to make future golangci-lint upgrades easier as otherwise unexpected linter might be included upon upgrade.
Fix #2333 #2334
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #2714: chore(ci): update to golangci-lint 1.42.x and use golangci/golangci-lint-action
Posted by GitBox <gi...@apache.org>.
tadayosi commented on pull request #2714:
URL: https://github.com/apache/camel-k/pull/2714#issuecomment-951664191
I found `TestMetrics` is flaky, especially this one `TestMetrics/reconciliation_duration_metric` is. I wonder if it really has anything to do with the changes I made for linting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #2714: chore(ci): update to golangci-lint 1.42.x and use golangci/golangci-lint-action
Posted by GitBox <gi...@apache.org>.
squakez commented on pull request #2714:
URL: https://github.com/apache/camel-k/pull/2714#issuecomment-989752631
Digging deeper:
```
Label: [
...
{
Name: "kind",
Value: "Kamelet",
...
{
Name: "result",
Value: "Reconciled",
...
},
...
],
...
Histogram: {
SampleCount: 272,
```
It seems that the reconciliation count for Kamelet is used instead of the Integration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #2714: chore(ci): update to golangci-lint 1.42.x and use golangci/golangci-lint-action
Posted by GitBox <gi...@apache.org>.
squakez commented on pull request #2714:
URL: https://github.com/apache/camel-k/pull/2714#issuecomment-989741240
Now that we don't truncate log, I can see the exact failure:
```
"Histogram": <*gstruct.PointerMatcher | 0xc0006c9740>{
Matcher: <*gstruct.FieldsMatcher | 0xc00066ed80>{
Fields: {
"SampleCount": <*gstruct.PointerMatcher | 0xc0006c9720>{
Matcher: <*matchers.EqualMatcher | 0xc000c5a500>{Expected: <uint64>12},
failure: "Expected\n <uint64>: 272\nto equal\n <uint64>: 12",
},
},
```
This is an excerpt from this failed build: https://github.com/apache/camel-k/runs/4446921484?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez removed a comment on pull request #2714: chore(ci): update to golangci-lint 1.42.x and use golangci/golangci-lint-action
Posted by GitBox <gi...@apache.org>.
squakez removed a comment on pull request #2714:
URL: https://github.com/apache/camel-k/pull/2714#issuecomment-989752631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #2714: chore(ci): update to golangci-lint 1.42.x and use golangci/golangci-lint-action
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2714:
URL: https://github.com/apache/camel-k/pull/2714#issuecomment-951677998
Yes, what I found is that there are some reconciliation errors that are not accounted for. For example, there are some for IntegrationPlatform reconciliation, which are now counted with: https://github.com/apache/camel-k/blob/fa32617ae33ba93c91b9c40b6cb9ecc98b23953c/e2e/common/operator_metrics_test.go#L240
It's possible other are missing.
At some point, it'd be valuable to assess the root cause of these errors. It seems they've been induced by the increasing amount of Kamelets being reconciled at the operator start time. Anyway, it's definitely not related to the changes introduced by this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org