You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/02/09 04:42:57 UTC

[GitHub] [incubator-eventmesh] zmt-Eason commented on a change in pull request #760: [Issue #655] Adding send message constraints for message size and batch size

zmt-Eason commented on a change in pull request #760:
URL: https://github.com/apache/incubator-eventmesh/pull/760#discussion_r802263718



##########
File path: eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/BatchSendMessageProcessor.java
##########
@@ -111,6 +112,18 @@ public void processRequest(ChannelHandlerContext ctx, AsyncContext<HttpCommand>
         String producerGroup = "";
         int eventSize = eventList.size();
 
+        if (eventSize > eventMeshHTTPServer.getEventMeshHttpConfiguration().eventMeshEventBatchSize) {

Review comment:
       可以考虑在AbstractHTTPServer的processEventMeshRequest里加消息体限制，可以避免在每个具体的processor里的重复代码




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org