You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2013/02/04 15:30:35 UTC
[Bug 54522] New: Add patch binary as prerequisite in BUILDING.txt
https://issues.apache.org/bugzilla/show_bug.cgi?id=54522
Bug ID: 54522
Summary: Add patch binary as prerequisite in BUILDING.txt
Product: Tomcat 8
Version: trunk
Hardware: PC
OS: Windows XP
Status: NEW
Severity: normal
Priority: P2
Component: Documentation
Assignee: dev@tomcat.apache.org
Reporter: ognjen.d.blagojevic@gmail.com
Classification: Unclassified
Commit r1360729 introduced one more dependency for building Tomcat, a 'patch'
executable.
Although 'patch' is usually available on Linux, and I guess Mac OS, it must be
installed on Windows, AFAIK. 'patch' executable for Windows is available here:
http://gnuwin32.sourceforge.net/packages/patch.htm
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 54522] Add patch binary as prerequisite in BUILDING.txt
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54522
Ognjen Blagojevic <og...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #29920|0 |1
is obsolete| |
--- Comment #4 from Ognjen Blagojevic <og...@gmail.com> ---
Created attachment 29925
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29925&action=edit
BUILDING.txt patch
Checkstyle errors fixed.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 54522] Add patch binary as prerequisite in BUILDING.txt
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54522
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #5 from Mark Thomas <ma...@apache.org> ---
This has been fixed by switching to (a snapshot of) DBCP2 which implemented
JDBC 4.1 so has no need of any patching.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 54522] Add patch binary as prerequisite in BUILDING.txt
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54522
Ognjen Blagojevic <og...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #29918|0 |1
is obsolete| |
--- Comment #2 from Ognjen Blagojevic <og...@gmail.com> ---
Created attachment 29920
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29920&action=edit
Patch
Small folder error corrected.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 54522] Add patch binary as prerequisite in BUILDING.txt
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54522
--- Comment #3 from Konstantin Kolinko <kn...@gmail.com> ---
Thank you for the patch.
Two notes on the original issue
1. I still hope that an updated version of commons-dbcp is released at some
time before Tomcat 8, so that using patch tool were not necessary.
2. As an alternative measure, it is possible to skip building DBCP.
Technically, it can be done by setting the property "no.build.dbcp", though it
is kind of a trick, as it is an internal property used to store result of a
<condition>. E.g.:
no.build.dbcp=true
(It would be better to have some explicit documented property to configure this
feature. Such as that it would skip not only building, but also downloading
DBCP sources).
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 54522] Add patch binary as prerequisite in BUILDING.txt
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54522
Ognjen Blagojevic <og...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
--- Comment #6 from Ognjen Blagojevic <og...@gmail.com> ---
Thank you.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 54522] Add patch binary as prerequisite in BUILDING.txt
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54522
--- Comment #1 from Ognjen Blagojevic <og...@gmail.com> ---
Created attachment 29918
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29918&action=edit
Patch
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org