[GitHub] [incubator-netbeans] borisheithecker commented on a change in pull request #1167: NETBEANS-2263 Integrate the localisation bundles from Oracle's 3rd donation into the current GitHub repository

[GitBox <gi...@apache.org>]

borisheithecker commented on a change in pull request #1167: NETBEANS-2263 Integrate the localisation bundles from Oracle's 3rd donation into the current GitHub repository
URL: https://github.com/apache/incubator-netbeans/pull/1167#discussion_r268527920
 
 

 ##########
 File path: netbeans-l10n/build.xml
 ##########
 @@ -85,7 +85,7 @@
         Probably you failed to clean your sources before updating. Try: ant hg-clean
     </fail>
     <!-- OK, continue: -->
-    <javac srcdir="antsrc" destdir="build/antclasses" deprecation="true" debug="true" source="1.5" target="1.5">
+    <javac srcdir="antsrc" destdir="build/antclasses" deprecation="true" debug="true" source="1.8" target="1.8">
 
 Review comment:
   Should, of course, be "Changed netbeans-l10n/build.xml to work with jdk8 or higher". 
   For whatever reason I couldn't run the script with jdk8 and source/target still set to level 1.5.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists